Binding OnIdiom inside IsVisible causes crash in release mode

the-crow-club commented 11 months ago

Description

If we use binding to a IsVisible property along with OnIdiom markup extension app crashes in release mode at InitiliazeCompenent(). Works fine on debug mode.

Ex : `

`

Steps to Reproduce

Create a new .net maui project
Add a class MainPageViewModel and define a bindable property "EnableLabel"
Im Mainpage.xaml create a label inside a stacklayout(or any) and bind it like this

`

4.Set the BindingContext in Mainpage.xaml.cs to MainPageViewModel 5.In MainPageViewModel constructor set EnableLabel to true

Build and deploy

Expected result : Wee se the label in phone in release mode

Actual result: App crashes in release mode . Works fine in debug mode

Link to public reproduction project repository

https://github.com/dotnet/maui/files/12414955/16725.zip

Version with bug

7.0.49

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android, I was not able test on other platforms

Affected platform versions

Android 13,Ios 16

Did you find any workaround?

Try to assign the IsVisble property in xaml.cs file instead of binding like below

 if(DeviceInfo.Idiom == DeviceIdiom.Phone)
{
    myControl.IsVisible = true;
}

Note* - myControl is x:Name of your control

or if you don't want assign it in xaml.cs bind Isvisible property without Onidiom markup extension and in viewmodel where ever you are assigning the property value use

 if(DeviceInfo.Idiom == DeviceIdiom.Phone)
{
    LabelVisible = true;
}
else
{
  LabelVisible = false;
}

Relevant log output

No response

ghost commented 11 months ago

Hi @the-crow-club. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

drasticactions commented 11 months ago

Having a GitHub repo with this code makes it easier for us to quickly debug, verify, and potentially fix the issue against a codebase that you can also test against to verify our changes, as well as use it to create test cases against in the future. I can understand that it can be tedious to do, but it will be helpful.

the-crow-club commented 11 months ago

@drasticactions Sorry but i cant provide git hub repo due to my limited access to github at my workspace

ghost commented 11 months ago

Hi @the-crow-club. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

the-crow-club commented 11 months ago

@XamlTest a bit of help here?

XamlTest commented 11 months ago

I can verify this issue on Visual Studio Enterprise 17.8.0 Preview 1.0. Repro on Android 13.0-API33 and iOS .NET 8, not repro on Windows 11 with below Project: 16725.zip

ghost commented 10 months ago

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

hwsmo commented 8 months ago

Hi, I can also confirm the bug. It cost me a lot of nerves until I found out that this was the case. Very frustrating :(

masoltani commented 4 months ago

Hi, I can also confirm the bug. It cost me a lot of nerves until I found out that this was the case. Very frustrating :(

Hi, I am facing the same issue with .NET 8.

formerlymisterhenson commented 2 months ago

Facing the same issue - as a workaround I created a converter (which basically does the conditional part mentionend by op)

dotnet / maui