search

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.21k stars 1.75k forks source link

MapWKUIDelegate conditional compilation for MacCatalyst #18394

Open tekmun opened 1 year ago

tekmun commented 1 year ago

Description

Add conditional compilation for MacCatalyst in https://github.com/dotnet/maui/blob/main/src/Core/src/Handlers/WebView/WebViewHandler.cs.

Add "|| MacCatalyst" on lines 15 and 31. Add "&& MacCatalyst" on line 9

In https://stackoverflow.com/questions/77170252/requestcapturemediapermission-for-wkwebview-in-maui-ios/77200328?noredirect=1#comment136198064_77200328, the given solution works only on iOS and not on MacCatalyst. The suspected reason is that the conditional compilation happens only for iOS.

Steps to Reproduce

No test case is needed.

Link to public reproduction project repository

No response

Version with bug

8.0.0-rc.2.9373

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

macOS

Affected platform versions

Mac 14

Did you find any workaround?

No.

Relevant log output

Not required.
ghost commented 1 year ago

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

jsuarezruiz commented 1 year ago

The issue will be fixed by https://github.com/dotnet/maui/tree/fix-18394

tekmun commented 1 year ago

Line 31 should be || MacCatalyst, not && MacCatalyst. When can I text this out using dotnet workload update?

tekmun commented 1 year ago

Line 31 should be || MacCatalyst, not && MacCatalyst. With AND operation, the conditional statement will not work on iOS and Mac. Please kindly change it! Thanks.