search

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.28k stars 1.76k forks source link

ImageButton ripple effect stops working with .NET 8 #18857

Closed FreakyAli closed 6 months ago

FreakyAli commented 1 year ago

Description

Ripple effect seems to stop working after upgrading to .NET 8 on all ImageButton for Android.

Relevant Screenshots

Steps to Reproduce

  1. Add an ImageButton to your page with padding,
  2. Notice how the default ripple effect stops working
iOS Android

Link to public reproduction project repository

https://github.com/FreakyAli/Maui.FreakyControls/tree/r4-gh/fix/pin-control

Version with bug

8.0.3

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

7.0.101

Affected platforms

Android

Affected platform versions

Android 12 and 13

Did you find any workaround?

NO

Relevant log output

No response

cropyai commented 1 year ago

I can confirm the issue, currently, we are having the same problem in Android app.

FreakyAli commented 1 year ago

@cropyai Yeah, the thing is ImageButtons and Buttons don't have Ripple effects, This is devastating, to be honest!!!

PureWeen commented 1 year ago

Related https://github.com/dotnet/maui/issues/18857

FreakyAli commented 1 year ago

Related #18857

@PureWeen I think you tagged the wrong issue here!!

albyrock87 commented 1 year ago

Is this same as https://github.com/dotnet/maui/issues/18924#issuecomment-1823279966 ?

XamlTest commented 11 months ago

Verified this on Visual Studio Enterprise 17.9.0 Preview 2(8.0.3). Repro on Android 14.0-API34, not repro on iOS 17.0 with below Project: MAUI.FreakyControls.zip

NoelleRousselle commented 10 months ago

I also can confirm this issue. Is there any workaround?

FreakyAli commented 10 months ago

I also can confirm this issue. Is there any workaround?

@NoelleRousselle There was no workaround for now so I created a lib with native click animations and started using Images https://github.com/FreakyAli/Maui.FreakyEffects

PureWeen commented 8 months ago

Duplicate of #17642

mattleibow commented 6 months ago

I split this issue into ripple and padding. This issue is now ripple-only. The new issue is for the padding: https://github.com/dotnet/maui/issues/22364

FreakyAli commented 6 months ago

@mattleibow This does not work with the latest version of .NET MAUI v8.0.40,

Why was this closed?

mattleibow commented 6 months ago

Why was this closed?

Typically, the issues are closed when the code is merged into the main branch. This does not mean that the issue is fixed and shipped. However, we have nightly builds that you can test and use.

We also release new versions to NuGet periodically outside of VS release schedules that you can use. This fix is not yet part of any official release.