Open sebfrie opened 8 months ago
We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.
Description
I implemented a custom action button in the Shell TabBar with a
CustomShellItemRenderer
derived fromShellItemRenderer
(following @VladislavAntonyuk's great blog post) but an added control (i.e., action button) does not react to settingShell.TabBarIsVisible
on a page.Making the
UpdateTabBarHidden
method in the iOS implementation ofShellItemRenderer
a protected virtual method would allow it to be overridden by derived classes which could handle added custom controls.Public API Changes
Make
UpdateTabBarHidden
in the iOS implementation ofShellItemRenderer
a protected virtual method instead of (implicitly) private. This would align with the Android implementation (see: ShellItemRenderer.cs)https://github.com/dotnet/maui/blob/c3221bf08d291c9f69070aa11d6d60f61a569aae/src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs#L434 ->
Intended Use-Case
This would allow for implementing a method that reacts to setting
Shell.TabBarIsVisible
and updates the visibility of added custom controls.The Android implementation of
ShellItemRenderer
already has a protected virtualUpdateTabBarVisibility
method that can be overridden in aCustomShellItemRenderer
to keep the visibility of the custom action button in sync:The API change would allow something similar for iOS: