The iOS keyboard is not fully retracted and requires an extra click on the “Done” button

ninachen03 commented 4 months ago

Description

The iOS keyboard is not fully retracted and requires an extra click on the “Done” button.

Steps to Reproduce

Deploy https://devdiv.visualstudio.com/Pkgs/_git/VS.TestAssets.Xaml?path=/Assets/Projects/ManualMauiTests to iOS simulator
Click or tap on category 'D' for 'RefreshView'.
Select the D4 or any editor page.
I/O ->Keyboard->Toggle Software keyboard ->Software keyboard is showing
Press any key on physical keyboard->The soft keyboard exits, but there is still a "Done" button in the lower right corner, which needs to be clicked to disappear completely.

Link to public reproduction project repository

https://devdiv.visualstudio.com/Pkgs/_git/VS.TestAssets.Xaml?path=/Assets/Projects/ManualMauiTests

Version with bug

8.0.40-nightly.10612+sha.752eed7129-azdo.9538080

Is this a regression from previous behavior?

This bug is not a regression, it can be reproduced in the latest stable release :8.0.3

Affected platforms

iOS

Did you find any workaround?

Added below code to MauiProgram.cs file

#if IOS
Microsoft.Maui.Handlers.EditorHandler.Mapper.AppendToMapping("EditorChange", (handler, view) =>
{
    handler.PlatformView.InputAccessoryView = null;
});
#endif

Relevant log output

No response

github-actions[bot] commented 4 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Clicking Editor in iOS creates an abnormal/undesirable "Done" bar above Touch Screen Keyboard, while clicking Entry does not cause this (correct function) (#17768), similarity score: 0.83
Hiding keyboard prevents button command from firing (#17819), similarity score: 0.76
[iOS] Disabled Editors Show Keyboard Partially When Tapped (#21059), similarity score: 0.75

Closed similar issues:

[iOS] Keyboard stays open when tapping outside of an entry (#19375), similarity score: 0.77
iOS keyboard "done" button does not call Editor.Completed and does not close the keyboard. (#10190), similarity score: 0.77

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

drasticactions commented 4 months ago

This is because the hardware keyboard is enabled for the simulator, so it'll show the "Done" button always when the editor is selected since it's an added element to the InputAccessoryView. If you ran it on a device without a hardware keyboard, it shouldn't appear.

That workaround would remove it from all uses of the keyboard though, unless you add it back for the software keyboard and remove it for the hardware one by detecting it. Also note that this InputAccessoryView is added by MAUI as part of its keyboard implementation, it's not the default for iOS. CC @tj-devel709.

gabsamples6 commented 4 months ago

Hi this one https://github.com/dotnet/maui/issues/17819 is causing issues for us and users complained that they have 2 press the button twice in iOS

We have an entry where a user can input an amount and a button exactly like the pic in 17819

they input the amount
press next button (does nothing)
keyboard now hides and button does nothing
press button now and works..
so they have to press it twice...

hope this can be addressed as we have no found any workaround

thanks

mattleibow commented 4 months ago

This issue is saying the accessory view is sticking around when you type on the host OS when using a simulator... which is not a real issue a user will hit since they have real devices with no host laptop.

But, can this issue occur in a normal app? Is there a real scenario that this could occur in?

developer9969 commented 4 months ago

@mattleibow we are having the same issue where a double tap is required on a real iOS device and because the issue is linked to https://github.com/dotnet/maui/issues/17819 would fixing this issue also fix https://github.com/dotnet/maui/issues/17819?

Works on android (no double tap)

mattleibow commented 4 months ago

I think this issue is not that we have to double tap but rather the Done button sticks around and has to be tapped to make it disappear.

mattleibow commented 1 month ago

This is causing an issue in this PR too: https://github.com/dotnet/maui/pull/20505

Instead of the keyboard going away, this is a non-editable editor that receives focus, but since it is not editable the keyboard does not appear and the done button does for some reason.

dotnet / maui