ImageButton Padding stops working with .NET 8

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.

https://dot.net/maui

MIT License

22.27k stars 1.76k forks source link

ImageButton Padding stops working with .NET 8 #22364

Closed mattleibow closed 6 months ago

mattleibow commented 6 months ago

Description

Padding seems to stop working after upgrading to .NET 8 on all ImageButton for Android.

Relevant Screenshots

Steps to Reproduce

Add an ImageButton to your page with padding, Notice how the padding is ignored on Android but works on iOS.

iOS	Android

Link to public reproduction project repository

https://github.com/FreakyAli/Maui.FreakyControls/tree/r4-gh/fix/pin-control

Version with bug

8.0.3

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

7.0.101

Affected platforms

Android

Affected platform versions

Android 12 and 13

Did you find any workaround?

Relevant log output

No response

github-actions[bot] commented 6 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

ImageButton Padding & Ripple effect stops working with .NET 8 (#18857), similarity score: 0.98
ImageButton Padding not working when manipulate IsVisible On Android (#16713), similarity score: 0.85
Padding on ImageButtons works wrong on Android (#13101), similarity score: 0.84
[ImageButton][Android] Padding is incorrect after IsVisible is changed (#18001), similarity score: 0.83
[regression/8.0.3] Flickering occurs due to padding while navigating pages. (#18875), similarity score: 0.81

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

FreakyAli commented 6 months ago

@mattleibow The latest version of MAUI does not fix this, Why was this closed?

NoelleRousselle commented 6 months ago

@mattleibow The latest version of MAUI does not fix this, Why was this closed?

I think it is part of the .NET 8 SR6 Milestone which is not finished yet

mattleibow commented 6 months ago

Why was this closed?

Typically, the issues are closed when the code is merged into the main branch. This does not mean that the issue is fixed and shipped. However, we have nightly builds that you can test and use.

We also release new versions to NuGet periodically outside of VS release schedules that you can use. This fix is not yet part of any official release.