[MAUI] The list does not show newly added recipes

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.

https://dot.net/maui

MIT License

21.96k stars 1.7k forks source link

[MAUI] The list does not show newly added recipes #22417

Closed kevinxufei closed 2 weeks ago

kevinxufei commented 3 months ago

Description

The list does not show newly added recipes

Note: The issue only repro on windows platform

Steps to Reproduce

Clone https://github.com/rachelkang/recipeSearch and deploy it to windows platform
Navigate to My Recipes-> 'New', and add new recipe.
The list does not show newly added recipes

Expected: The list should show newly added recipes

Actual: The list does not show newly added recipes maui4

Link to public reproduction project repository

https://github.com/rachelkang/recipeSearch.git

Version with bug

Microsoft.Maui.Controls 8.0.60-ci.net8.10665+azdo.9579251

Is this a regression from previous behavior?

This bug is a regression, it can be reproduced in 8.0.40, but can not be reproduced in 8.0.3, and it works fine on Microsoft.Maui.Controls 8.0.40-nightly.10612+sha.752eed7129-azdo.9538080.

Affected platforms

Windows

github-actions[bot] commented 3 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

[MAUI][.NET8] Newly created recipes cannot be deleted. (#16020), similarity score: 0.75
[Windows] New CarouselView item doesn't render unless Window is resized (#17830), similarity score: 0.71
[MAUI][.NET9] Clicking on any recipe page shows blank (#21032), similarity score: 0.71

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

jsuarezruiz commented 3 months ago

I have been reviewing it:

We recently applied changes to the CarouselViewHandler https://github.com/dotnet/maui/pull/22222 We updated the ItemsSource under different conditions: changes in the size of the control or window, etc.
When adding items, we no longer set the ItemsSource again and the UI does not refresh although internally everything is done correctly. Using a CollectionViewSourcewith the ListViewBase of the CarouselView on Windows, everything works correctly although this would break the Loop property. Using LoopableCollectionView, the UI is not updated. Therefore, the focus is currently on reviewing this implementation. We could override and reset ItemsSource but it is a non-optimal solution.

RoiChen001 commented 3 weeks ago

Update: This issue no longer occurs in 8.0.80.