BindableObjects not getting collected causing memory leak, android

GBarbieri-IPS commented 2 weeks ago

Description

I have a pretty large application that we migrated over from xamarin to MAUI. Seems that after navigating through our app x~40 times we end up with a memory leak causing the application to hang. I've collected memory dumps at the time of the crash which I'll post here.

image (1) image (2)

I can see that MIcrosoft.Maui.Controls.SetterSpecificiityList and BindablePropertyContext seem to be eating up a bunch of our resources as dead objects. I was wondering if there was a way to get these bindings to be cleaned up by the GC as I believe these seem to be the cause of our memory leak? I've tried traversing through the visual tree, removing handlers, setting binding context to null, setting the styles to null, unapplying bindings upon disposal. Can't see to get any progress on resolving this issue.

Steps to Reproduce

Navigating through 5 pages of our app
Navigating back to root
Repeat 22 times
Notice application hangs during OnAppearing or OnPageDisappearing

Link to public reproduction project repository

No response

Version with bug

8.0.21 SR4.1

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

No response

Did you find any workaround?

No workaround yet.

Relevant log output

No response

github-actions[bot] commented 2 weeks ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Memory leak when VisualElement are no longer in view on Android (#21853), similarity score: 0.78

Closed similar issues:

Memory leaks EVERYWHERE (#12039), similarity score: 0.81
Widespread memory leak propagation in visual trees (#21809), similarity score: 0.80
Memory Leak on back and Fro navigation on page where Custom control and complex View Page (#21404), similarity score: 0.80
Memory Leak on Page Navigation while removing the page. (#21403), similarity score: 0.78

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

Toomas75 commented 2 weeks ago

I had problems with SetterSpecificiityList when used BindableLayout and loaded itemtemplate in non ui thread.

GBarbieri-IPS commented 2 weeks ago

@Toomas75 Were you seeing similar issues as to what I mentioned? If so how did you get around it? Thanks :)

Toomas75 commented 2 weeks ago

@Toomas75 Were you seeing similar issues as to what I mentioned? If so how did you get around it? Thanks :)

Just checked my history. It wasn't views leaking problem as you experience.

dotnet / maui