WebAuthenticatorResult fails in release mode "Newtonsoft.Json.JsonSerializationException: A member with the name '' already exists on 'Microsoft.Maui.Authentication.WebAuthenticatorResult'. Use the JsonPropertyAttribute to specify another name."

ckapatch commented 2 weeks ago

Description

We are using WebAuthenticator to authenticate users with a backend. using the standard setup described in this document: https://learn.microsoft.com/en-us/dotnet/maui/platform-integration/communication/authentication?view=net-maui-8.0&tabs=windows

After implementing and testing in debug mode, we released a version on the android store to begin some external testing. The authentication failed in this environment with the error "Newtonsoft.Json.JsonSerializationException: A member with the name '' already exists on 'Microsoft.Maui.Authentication.WebAuthenticatorResult'. Use the JsonPropertyAttribute to specify another name."

Steps to Reproduce

Implement WebAuthenticator using the above guide
Compile and run the Maui Android application in release mode.
Trigger the WebAuthenticator to start the authentication process.
Observe that the application logs the JsonSerializationException and fails to proceed with the authentication.

Link to public reproduction project repository

No response

Version with bug

8.0.80 SR8

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 11 and up

Did you find any workaround?

Yes, if you disable AOT and remove trimming the app will work.

Relevant log output

ewtonsoft.Json.JsonSerializationException: A member with the name '' already exists on 'Microsoft.Maui.Authentication.WebAuthenticatorResult'. Use the JsonPropertyAttribute to specify another name.
   at Newtonsoft.Json.Serialization.JsonPropertyCollection.AddProperty(JsonProperty property)
   at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateConstructorParameters(ConstructorInfo constructor, JsonPropertyCollection memberProperties)
   at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateObjectContract(Type objectType)
   at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateContract(Type objectType)
   at System.Collections.Concurrent.ConcurrentDictionary`2[[System.Type, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[Newtonsoft.Json.Serialization.JsonContract, Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed]].GetOrAdd(Type , Func`2 )
   at Newtonsoft.Json.Utilities.ThreadSafeStore`2[[System.Type, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[Newtonsoft.Json.Serialization.JsonContract, Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed]].Get(Type key)
   at Newtonsoft.Json.Serialization.DefaultContractResolver.ResolveContract(Type type)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.GetContract(Object value)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.GetContractSafe(Object value)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize(JsonWriter jsonWriter, Object value, Type objectType)
   at Newtonsoft.Json.JsonSerializer.SerializeInternal(JsonWriter jsonWriter, Object value, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Serialize(JsonWriter jsonWriter, Object value, Type objectType)
   at Newtonsoft.Json.JsonConvert.SerializeObjectInternal(Object value, Type type, JsonSerializer jsonSerializer)
   at Newtonsoft.Json.JsonConvert.SerializeObject(Object value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.SerializeObject(Object value)

github-actions[bot] commented 2 weeks ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

WebAuthenticator crash with some browsers (#13302), similarity score: 0.73
Newtonsoft.Json deserialization fails in Release build, works fine in Debug build (#13033), similarity score: 0.72
WebAuthenticator in Android not working (#6534), similarity score: 0.72
WebAuthenticator VirtualView cannot be null (#20667), similarity score: 0.72
WebAuthenticator on Windows throws unhelpful errors (#23616), similarity score: 0.70

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

drasticactions commented 2 weeks ago

Can you create a reproduction project for what you're doing here? At least the MAUI UI App portion?

As far as I can tell, the docs don't recommend using JSON.NET, and the underlying code doesn't either. The sample in the doc you linked to doesn't either from what I can see, so I'm not sure how that would happen based on your info above.

Also for AOT/Trimming use-cases, IMO, I would move away from JSON.NET and to something like System.Text.Json, which supports it through source generators.

dotnet-policy-service[bot] commented 2 weeks ago

Hi @ckapatch. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

dotnet-policy-service[bot] commented 1 week ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback to reproduce the issue but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. If it is closed, feel free to comment when you are able to provide the additional information and we will re-investigate.

dotnet / maui