dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.27k stars 1.76k forks source link

Fixed Shell Navigating event issue when switching tabs #25749

Open Vignesh-SF3580 opened 2 weeks ago

Vignesh-SF3580 commented 2 weeks ago

Issue Detail

Mac and iOS: Clicking on an already-selected tab triggered the Navigating event unnecessarily. Windows: The Navigating event was not triggered when switching tabs.

Root Cause

Mac and iOS: The event was triggered without checking if the tab was already selected. Windows: There was no code in place to trigger the Navigating event upon tab switches.

Description of Change

Mac and iOS: Modified the code to trigger Navigating only if a new tab is selected. Windows: Added logic to trigger Navigating when switching to a different tab.

Tested the behaviour in the following platforms

Issues Fixed

Fixes https://github.com/dotnet/maui/issues/25599

Screenshots

Before Issue Fix After Issue Fix
dotnet-policy-service[bot] commented 2 weeks ago

Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago
Azure Pipelines successfully started running 3 pipeline(s).
jsuarezruiz commented 1 week ago

/azp run

rmarinho commented 1 week ago

/rebase

rmarinho commented 1 week ago

/azp run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 3 pipeline(s).
jsuarezruiz commented 3 days ago

/azp run