search

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.25k stars 1.76k forks source link

[Enhancement] Shell TItleBar(?) text with tabbed and non tabbed content #5683

Open emceelovin opened 2 years ago

emceelovin commented 2 years ago

Description

The Shell content titlebar(at least I think that's what it is) at the top, underneath the main titlebar(what are the plans for this with desktop apps btw?), should display differently according to what content is being displayed. When using Tabbed content, Tab uses the title of the first ShellContent page as the title text. I'm not sure if that's intended behavior, or a bug, but I feel like with Tabbed content, the title should be the FlyoutItem's title. Using the ShellContent page titles is redundant. The name of the first page will be in the titlebar AND the tab text. When the content of a FlyoutItem is just a single page, that would make sense to use the page's title, but in reality, it should still use the FlyoutItem's title. Feel free to guide me, but isn't the purpose of the titlebar to be in correlation with the FlyoutOut, or no?

A work around for this, is to name every ShellContent's Page.Title in my FlyoutItem the same name as the FlyoutItem.Title, and then it's 100% the way I think it should be. Open to any criticism and comments by all means.

Also, is it possible to change the titlebar color from black?

Example: shell_content_title

Public API Changes

n/a

Intended Use-Case

n/a

PureWeen commented 2 years ago

@emceelovin this is a tricky one. I went around with @rachelkang on this behavior when we worked on https://github.com/dotnet/maui/pull/5113 . What if users don't want any title in the title bar? This behavior makes it tricky to remove the Flyout Item title that is now being used for the Page.Title. I'm even a little regretful we made it so the ShellContent.Title is used for the page title. It's tricky when you have a single property do multiple things but then some users want to opt out of a few of those.

ghost commented 2 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.