dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
21.83k stars 1.67k forks source link

[IOS] Make MauiWebViewNavigationDelegate public methods virtual #7551

Open danielftz opened 2 years ago

danielftz commented 2 years ago

Description

I would like to have MauiWebViewNavigationDelegate public methods

public void DidFinishNavigation(WKWebView webView, WKNavigation navigation)
public void DidFailNavigation(WKWebView webView, WKNavigation navigation, NSError error)
public void DidFailProvisionalNavigation(WKWebView webView, WKNavigation navigation, NSError error)
public void DecidePolicy(WKWebView webView, WKNavigationAction navigationAction, Action<WKNavigationActionPolicy> decisionHandler)

to be virtual, the same way they are in WKNavigationDelegate

Public API Changes

public virtual void DidFinishNavigation(WKWebView webView, WKNavigation navigation)
public virtual void DidFailNavigation(WKWebView webView, WKNavigation navigation, NSError error)
public virtual void DidFailProvisionalNavigation(WKWebView webView, WKNavigation navigation, NSError error)
public virtual void DecidePolicy(WKWebView webView, WKNavigationAction navigationAction, Action<WKNavigationActionPolicy> decisionHandler)

Intended Use-Case

public override void DidFinishNavigation(WKWebView webView, WKNavigation navigation)
{
    base.DidFinishNavigation(webView, navigation);
}
ghost commented 1 year ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

maonaoda commented 1 month ago

@jfversluis @Eilon It has been a long time. May I ask what the result of this proposal is? I don't think it should be a difficult thing.