search

dotnet / maui

.NET MAUI is the .NET Multi-platform App UI, a framework for building native device applications spanning mobile, tablet, and desktop.
https://dot.net/maui
MIT License
22.23k stars 1.76k forks source link

Replace/implement image comparison for device/unit tests #8661

Open mattleibow opened 2 years ago

mattleibow commented 2 years ago

Description

We need a way to actually compare images - both on device and in unit tests - to make sure we have a way to test image differences.

I have some SkiaSharp diff code in the unit tests, but we need a way to generalize this so that we can test that changes to say a border thickness is correctly fixed in all the platforms.

Did you check if we could use an assertion library like Verify?

https://github.com/VerifyTests/Verify

Might simplify some of the test code.

There is an older one called ApprovalTests, but it only worked on Windows.

_Originally posted by @jonathanpeppers in https://github.com/dotnet/maui/pull/8020#discussion_r898034981_

ghost commented 1 year ago

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.