Closed JanKrivanek closed 3 months ago
The addition to the binlog might be bundled with BuildCheckTracingEventArgs
de/serialization - in order to minimize formats bumps
Suggested location to publish the event: https://github.com/dotnet/msbuild/blob/06bb1c233fd4f2cd136ba3bbbfcb4b553a2eceb6/src/Build/BackEnd/BuildManager/BuildManager.cs#L1378
Context
We need to distinguish restore is happening for the BuildCheck feature (namely for https://github.com/dotnet/msbuild/issues/9747) This is not currently possible until receiving BuildEvaluationFinished. Team decided that it's more future wise to add the full event with all the relevant info, rather than reusing BuildEvaluationStarted event.
Blocked by: https://github.com/dotnet/msbuild/pull/10172
What should be done
BuildRequestData
andGraphBuildRequestData
introduced in https://github.com/dotnet/msbuild/pull/10172):PendBuildRequest
functions)Additional notes
This work would ideally unify with:
BuildCheckTracingEventArgs
de/serialization