dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.
https://docs.microsoft.com/visualstudio/msbuild/msbuild
MIT License
5.24k stars 1.35k forks source link

Add BuildSubmissionStartedEventArgs event #10145

Closed JanKrivanek closed 3 months ago

JanKrivanek commented 6 months ago

Context

We need to distinguish restore is happening for the BuildCheck feature (namely for https://github.com/dotnet/msbuild/issues/9747) This is not currently possible until receiving BuildEvaluationFinished. Team decided that it's more future wise to add the full event with all the relevant info, rather than reusing BuildEvaluationStarted event.

Blocked by: https://github.com/dotnet/msbuild/pull/10172

What should be done

Additional notes

This work would ideally unify with:

JanKrivanek commented 6 months ago

The addition to the binlog might be bundled with BuildCheckTracingEventArgs de/serialization - in order to minimize formats bumps

JanKrivanek commented 4 months ago

Suggested location to publish the event: https://github.com/dotnet/msbuild/blob/06bb1c233fd4f2cd136ba3bbbfcb4b553a2eceb6/src/Build/BackEnd/BuildManager/BuildManager.cs#L1378