search

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.
https://docs.microsoft.com/visualstudio/msbuild/msbuild
MIT License
5.19k stars 1.35k forks source link

[Feature Request]: Reduce the wrapping around SDK Resolver messages when only one resolver is actually invoked #10191

Open baronfel opened 1 month ago

baronfel commented 1 month ago

Summary

In https://github.com/dotnet/sdk/pull/41268 I was able to use the SDK Resolver features to ensure that only the NuGet SDK resolver was used for a restore. In this case we should be able to remove MSBuild wrapping around the 'error list' and only surface the single Resolver's message.

Background and Motivation

We want to remove visual noise around error experiences and make it easier for users to diagnose the core problems.

Proposed Feature

https://github.com/dotnet/msbuild/blob/003252215533cca375dfc6578d8cb9e029418f37/src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs#L277-L280 should change the way it logs to not log the wrapper if only one resolver was used.

Alternative Designs

No response

AR-May commented 1 month ago

Makes sense to me. A small change in logging.