search

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.
https://docs.microsoft.com/visualstudio/msbuild/msbuild
MIT License
5.21k stars 1.35k forks source link

Put MSBuild sources on Index during microbuild #1592

Closed cdmihai closed 4 years ago

cdmihai commented 7 years ago

MSBuild's sources on Index are stale. I don't think they have been updated since MSBuild moved to Github. To not confuse the rest of the organization that uses Index, we should update our microbuild to upload sources on Index.

cdmihai commented 7 years ago

Or maybe there's a web service we can call when a Pull Request goes into the main branch.

KirillOsenkov commented 7 years ago

I can look into this in a couple of weeks. The problem here isn't uploading MSBuild sources from GitHub, it's not uploading them from the DevDiv repo ;) I'll need to come up with a filter that excludes old MSBuild sources, reindex DevDiv, then overlay MSBuild sources from GitHub on top of that :) So that we don't have duplicates in the index.

KirillOsenkov commented 7 years ago

Here's another question: which branch should be uploaded? Which is the most useful branch to have on index? Unfortunately we can only have one.

cdmihai commented 7 years ago

Thanks! Out current main branch is xplat. Post RTM though, we plan on making xplat the new master.

jeffkl commented 7 years ago

I had our sources put on http://source.dot.net, is that good enough? Our current branch is xplat.

cdmihai commented 7 years ago

@jeffkl The problem is that most people search on Index, so we should keep all source sites up to date (index, source.dot.net, cdx?). Or remove sources entirely from the sites we don't want to support anymore, otherwise people will make wrong assumptions about the code.

KirillOsenkov commented 7 years ago

So I've excluded the old MSBuild sources from DevDiv and added the new sources from the xplat branch.

The remaining work is to automate updating the sources as part of the CI build, I can take care of this a bit later.

rainersigwald commented 7 years ago

That's awesome, @KirillOsenkov. xplat is probably the best branch for the long term. We may rename it at some point but not in the near future.

KirillOsenkov commented 4 years ago

This is now fixed