Handle sln files in the ProjectGraph

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.

https://docs.microsoft.com/visualstudio/msbuild/msbuild

MIT License

5.17k stars 1.34k forks source link

Handle sln files in the ProjectGraph #3793

Open dfederm opened 5 years ago

dfederm commented 5 years ago

Need to be able to take sln files as input.

Some open questions:

Is the sln just converted to a metaproj?
Does the sln have its own node?

rainersigwald commented 5 years ago

My educated guess is:

Use the metaproject
Yes, create a node for the metaproj
After loading the metaproject, just use the existing ProjectReference magic. It may require some tweaking since the <MSBuild call in the metaproj differs from the one in common.targets.

dfederm commented 5 years ago

That's what I was thinking as well. It does imply that in general "traversal" projects are part of the graph though. That's probably the correct behavior anyway, as consumers (like QuickBuild) can just filter those nodes out if they don't want them. Generally speaking, traversal projects could have arbitrary logic in custom targets though, so need to be built in the pure MSBuild case. MSBuild can't make the same assumptions/require the same restrictions QuickBuild can.

rainersigwald commented 5 years ago

Yeah, I think traversal projects are in the graph; they should just execute quickly.