Binary logger should respect verbosity

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.

https://docs.microsoft.com/visualstudio/msbuild/msbuild

MIT License

5.22k stars 1.35k forks source link

Binary logger should respect verbosity #4543

Open KirillOsenkov opened 5 years ago

KirillOsenkov commented 5 years ago

Currently the Binary Logger forces verbosity to diagnostic: https://github.com/microsoft/msbuild/blob/bd233ed5dd20725c79b16d907634874237267d77/src/MSBuild/XMake.cs#L3043

This has side effects, such as forcing Log Task Inputs and DetailedSummary. We should probably respect the ambient verbosity if specified explicitly. Still default to diagnostic if /bl is specified and the verbosity isn't specified.

rainersigwald commented 1 year ago

Reopening because we're reverting #8805 to fix #8845.