search

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.
https://docs.microsoft.com/visualstudio/msbuild/msbuild
MIT License
5.21k stars 1.35k forks source link

Evaluation started / ended events do not get logged in file / console loggers #4739

Open cdmihai opened 4 years ago

cdmihai commented 4 years ago

Steps to reproduce

dotnet new console
dotnet msbuild /fl /flp:vebosity=diagnostic /clp:verbosity=diagnostic > out

Expected behavior

out and msbuild.log contain evaluation started / ended events which wrap around the events coming from that evaluation (evaluation events get indented one level deeper under the evaluation started / ended events)

Actual behavior

The log files do not contain these events

Cause

It seems the FileLogger does not log all events, it treats each event type separately. The evaluation started / ended events slip through the cracks and do not get logged. The binary logger does write them out, because it does not discriminate on the event type.

livarcocc commented 4 years ago

Not really sure if this is appropriate for you @Forgind, but I will let you try it out and let me know if you need to learn some more before tackling an issue like this.