Project-wide whitespace cleanup

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.

https://docs.microsoft.com/visualstudio/msbuild/msbuild

MIT License

5.18k stars 1.34k forks source link

Project-wide whitespace cleanup #4779

Open treymerkley opened 4 years ago

treymerkley commented 4 years ago

So while working on src/Tasks/GenerateResource.cs I accidentally found that there's a relatively large amount of whitespace in the entire MSBuild project. Can I clean this up? I'll do it programmatically of course, and (once I find one) I'll insert the function I use.

rainersigwald commented 4 years ago

Let's limit it to only trailing whitespace, but yeah, I think we'd take a PR to do that.

Areas to be careful of:

Try not to change whitespace inside string literals
Is anything in our MSBuild logic whitespace-sensitive? I sure hope not!

treymerkley commented 4 years ago

only trailing? I should be able to do that.

Rather than trying to clean the whole project at once then, what if I went a folder at a time, starting at the root, that way any bugs that arise are immediately noticeable and easier to fix?

rainersigwald commented 4 years ago

Seems reasonable to me!

treymerkley commented 4 years ago

So I'm just using https://github.com/purcell/whitespace-cleanup-mode and doing it on a file-by-file basis so it's easier to track down what broke in the event something is whitespace dependent.