Since this won't affect external customers, we shouldn't make it run every time someone builds. It might be reasonable to take the location and output a warning if running Deploy-MSBuild without specifying Core to a folder under sdk.
One other idea I had is to beef up Deploy-MSBuild.ps1 so that it detects core/full based on heuristics and picks itself. Maybe your "folder under sdk" is sufficient for that?
Steps to reproduce
1) Build MSBuild
.\build.cmd /p:CreateBootstrap=true
) 2) Deploy itpowershell.exe
, thenscripts\Deploy-MSBuild.ps1
dotnet build
(typically under Program Files\dotnet\sdk). 3) Rundotnet build
on anything.Expected behavior
Some indicator that you built targeting Framework but tried to run MSBuild as if you'd targeted Core.
Actual behavior
Build Failed 0 Warning(s) 0 Error(s)
msbuild.log
msbuild.txt (Change the latter to a binlog)
Since this won't affect external customers, we shouldn't make it run every time someone builds. It might be reasonable to take the location and output a warning if running
Deploy-MSBuild
without specifying Core to a folder under sdk.