search

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.
https://docs.microsoft.com/visualstudio/msbuild/msbuild
MIT License
5.19k stars 1.35k forks source link

[NETSDKE2E][Loc]With NET9 SDK installed in loc OS(Chinese), Unit of time in message is missing when creating project in CLI. #9601

Open vdanche opened 6 months ago

vdanche commented 6 months ago
  1. Install 9.0.100-alpha.1.24053.14 in Loc OS(e.g Chinese OS)
  2. Run "dotnet new console" in CLI.
  3. Check if the messages are localized well.

Expected Result: the messages are localized well.

Actual Result: Unit of time in message is missing.

Chinese(Repro) image

EN: image

German(not repro) image

C:\Users\v-danche>dotnet --info .NET SDK: Version: 9.0.100-alpha.1.24053.14 Commit: 48543d2076 Workload version: 9.0.100-manifests.b3326be0

运行时环境: OS Name: Windows OS Version: 10.0.22621 OS Platform: Windows RID: win-x64 Base Path: C:\Program Files\dotnet\sdk\9.0.100-alpha.1.24053.14\

已安装 .NET 工作负载: 没有要显示的已安装工作负载。

Host: Version: 9.0.0-alpha.1.24053.1 Architecture: x64 Commit: cc26196708

.NET SDKs installed: 9.0.100-alpha.1.24053.14 [C:\Program Files\dotnet\sdk]

.NET runtimes installed: Microsoft.AspNetCore.App 9.0.0-alpha.1.23620.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.NETCore.App 9.0.0-alpha.1.24053.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.WindowsDesktop.App 9.0.0-alpha.1.24053.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found: None

Environment variables: Not set

global.json file: Not found

Learn more: https://aka.ms/dotnet/info

Download .NET: https://aka.ms/dotnet/download

dotnet-issue-labeler[bot] commented 6 months ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

marcpopMSFT commented 6 months ago

This appears to be the new terminal logger output so routing to msbuild and marking it for TL tracking.

vdanche commented 5 months ago

we checked on today's build 9.0.100-preview.1.24101.4 SDK on Chinese OS. the time unit is added for log output after running "dotnet new console" image

But the time unit is still missing after running "dotnet build" image

AR-May commented 4 months ago

It should be already fixed with the fix of this issue: https://ceapex.visualstudio.com/CEINTL/_workitems/edit/935605

vdanche commented 4 months ago

@AR-May It still happen when building project on Chinese OS on 9.0.100-preview.3.24165.20(runtime-9.0.0-preview.3.24162.31), Do we need to file a new bug for it? image

EN: image

AR-May commented 4 months ago

It seems like not everything was indeed fixed by the issue that I mentioned. I will reopen this issue, no need to create new one.

AR-May commented 4 months ago

Team triage: @JaynieBai Could you please fill a localization bug like the one I mentioned above.

JaynieBai commented 4 months ago

Team triage: @JaynieBai Could you please fill a localization bug like the one I mentioned above.

Log bug https://ceapex.visualstudio.com/CEINTL/_workitems/edit/956251

JaynieBai commented 3 months ago

Translated in localization PR https://github.com/dotnet/msbuild/pull/10003

vdanche commented 3 months ago

@AR-May we checked on 9.0.100-preview.4.24224.4 Now, the unit of time can be displayed well after running "dotnet build" image But when we run "dotnet build -f net9.0", unit of time is still missing image

EN image

AR-May commented 3 months ago

When you set up the framework, it is a separate string indeed. And it is not translated well it seems. @JaynieBai could you please open a loc bug for it too?