Closed joaopgrassi closed 3 years ago
Merging #130 (1bbdccd) into main (d114dc6) will increase coverage by
1.06%
. The diff coverage is76.00%
.
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 90.05% 91.12% +1.06%
==========================================
Files 28 28
Lines 342 428 +86
Branches 30 33 +3
==========================================
+ Hits 308 390 +82
- Misses 26 29 +3
- Partials 8 9 +1
Impacted Files | Coverage Δ | |
---|---|---|
...uGetTrends.Web/Portal/src/app/app-routes.module.ts | 100.00% <ø> (ø) |
|
...rc/NuGetTrends.Web/Portal/src/app/app.component.ts | 100.00% <ø> (ø) |
|
...NuGetTrends.Web/Portal/src/app/core/core.module.ts | 100.00% <ø> (ø) |
|
...Web/Portal/src/app/core/footer/footer.component.ts | 100.00% <ø> (ø) |
|
...al/src/app/core/navigation/navigation.component.ts | 100.00% <ø> (ø) |
|
...b/Portal/src/app/core/services/packages.service.ts | 100.00% <ø> (ø) |
|
...rtal/src/app/core/services/social-share.service.ts | 34.78% <0.00%> (ø) |
|
...etTrends.Web/Portal/src/app/home/home.component.ts | 100.00% <ø> (ø) |
|
...NuGetTrends.Web/Portal/src/app/home/home.module.ts | 100.00% <ø> (ø) |
|
...GetTrends.Web/Portal/src/app/mocks/toaster-mock.ts | 100.00% <ø> (ø) |
|
... and 34 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d114dc6...1bbdccd. Read the comment docs.
To make the deployment process easier, we decided to make the API serve the static SPA files. In summary this is what needs to be done:
Api
toWeb
NuGetTrends.Spa/*
toNuGetTrends.Web/Portal