dotnet / nuget-trends

Check out NuGet packages adoption and what's trending on NuGet.
https://nugettrends.com
MIT License
146 stars 25 forks source link

Ensure download counts can go beyond 2.4B #134

Open bruno-garcia opened 3 years ago

bruno-garcia commented 3 years ago

As Newtonsoft.Json's count is reaching int.MaxValue, this issue was raised: https://github.com/NuGet/NuGetGallery/issues/8476

At first glance, we're using long already for the count:

https://github.com/dotnet/nuget-trends/blob/dac67d1bd4707a94063b843571127eb055a4cc4f/src/NuGetTrends.Data/DailyDownload.cs#L9

We need to make sure things will work fine once values overflow a signed 32bit integer max value.