search

dotnet / nuget-trends

Check out NuGet packages adoption and what's trending on NuGet.
https://nugettrends.com
MIT License
150 stars 28 forks source link

Put all services inside docker-compose #147

Open Tyrrrz opened 3 years ago

Tyrrrz commented 3 years ago

Currently, only postgres and rabbitmq are included in docker-compose.yml. It would be extremely convenient for new contributors if that also contained frontend/backend/worker services as well.

joaopgrassi commented 3 years ago

I guess it depends on which part of the project you are working on. If you are working on the front-end, then it's only necessary to run the db+api. So maybe we could have multiple compose files that makes sense for each contributor "area"?

Tyrrrz commented 3 years ago

You can actually have one compose file, but then do docker-compose up service1 service2 to selectively run services, it's quite convenient. The default would be to run them all, but if you're working on one of the services you can selectively exclude it and run everything else.

joaopgrassi commented 3 years ago

Yep, that also works. One "downside" of this approach is that I have to remember to type all the services I need so :smile:. Wheres if we have the individual compose-spa then I can just run that. Lazy I know.. Either way it's an improvement from what we have today hehe.

Tyrrrz commented 3 years ago

You could probably also implement compose-without-frontend and compose-without-backend as batch files/shell scripts.

joaopgrassi commented 3 years ago

Good idea! That would be the best of both worlds then :).