Closed joaopgrassi closed 3 years ago
Merging #149 (22e1ab1) into main (445ccab) will decrease coverage by
0.23%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 90.97% 90.74% -0.24%
==========================================
Files 28 28
Lines 432 432
Branches 32 32
==========================================
- Hits 393 392 -1
Misses 29 29
- Partials 10 11 +1
Impacted Files | Coverage Δ | |
---|---|---|
...s/loading-indicator/loading-indicator.component.ts | 92.85% <0.00%> (-7.15%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 445ccab...22e1ab1. Read the comment docs.
@joaopgrassi are we uploading these to Sentry in CI or do we need some automation for it?
No, we are not uploading them today to Sentry. Need to add to the CI build I guess.
Oh do we publish the sourcemaps with the site? Sentry can fetch from it since it's a public site. Either that or we should start uploading otherwise it's not helpful to see minified stack traces
It's published together with the site, so I guess it should be working already? For ex you can debug the app on nugettrends.com since the source maps are just public. Do we need to configure something on Sentry then?
Ok I read this https://docs.sentry.io/platforms/javascript/guides/angular/sourcemaps/hosting-publicly/ and it seems all is prepared for it. The minified js files already have this url at the bottom:
Now just need to check if Sentry is able to fetch the files from the server. If not then I guess we need to push from CI.
Seems to be working already there are events there with source and everything
Missed this during the upgrade. Now it generates them.![image](https://user-images.githubusercontent.com/5938087/118362740-05f8aa00-b591-11eb-998f-ca9609b32ea6.png)