dotnet / nuget-trends

Check out NuGet packages adoption and what's trending on NuGet.
https://nugettrends.com
MIT License
146 stars 25 forks source link

Fix not generating source maps #149

Closed joaopgrassi closed 3 years ago

joaopgrassi commented 3 years ago

Missed this during the upgrade. Now it generates them. image

codecov[bot] commented 3 years ago

Codecov Report

Merging #149 (22e1ab1) into main (445ccab) will decrease coverage by 0.23%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   90.97%   90.74%   -0.24%     
==========================================
  Files          28       28              
  Lines         432      432              
  Branches       32       32              
==========================================
- Hits          393      392       -1     
  Misses         29       29              
- Partials       10       11       +1     
Impacted Files Coverage Δ
...s/loading-indicator/loading-indicator.component.ts 92.85% <0.00%> (-7.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 445ccab...22e1ab1. Read the comment docs.

bruno-garcia commented 3 years ago

@joaopgrassi are we uploading these to Sentry in CI or do we need some automation for it?

joaopgrassi commented 3 years ago

No, we are not uploading them today to Sentry. Need to add to the CI build I guess.

bruno-garcia commented 3 years ago

Oh do we publish the sourcemaps with the site? Sentry can fetch from it since it's a public site. Either that or we should start uploading otherwise it's not helpful to see minified stack traces

joaopgrassi commented 3 years ago

It's published together with the site, so I guess it should be working already? For ex you can debug the app on nugettrends.com since the source maps are just public. Do we need to configure something on Sentry then?

Ok I read this https://docs.sentry.io/platforms/javascript/guides/angular/sourcemaps/hosting-publicly/ and it seems all is prepared for it. The minified js files already have this url at the bottom:

image

Now just need to check if Sentry is able to fetch the files from the server. If not then I guess we need to push from CI.

bruno-garcia commented 3 years ago

image Seems to be working already there are events there with source and everything

bruno-garcia commented 3 years ago

image