search

dotnet / nuget-trends

Check out NuGet packages adoption and what's trending on NuGet.
https://nugettrends.com
MIT License
150 stars 28 forks source link

detect unoptimized assemblies #151

Closed bruno-garcia closed 3 years ago

bruno-garcia commented 3 years ago

Adding https://github.com/bruno-garcia/unoptimized-assembly-detector

For example, adding:

<PackageReference Include="structuremap" Version="4.4.0" />

To src/NuGetTrends.Data/NuGetTrends.Data.csproj

Results in a build with warnings:

  Determining projects to restore...
  Restored /Users/bruno/git/nuget-trends/src/NuGetTrends.Web/NuGetTrends.Web.csproj (in 398 ms).
  Restored /Users/bruno/git/nuget-trends/src/NuGetTrends.Scheduler/NuGetTrends.Scheduler.csproj (in 398 ms).
  Restored /Users/bruno/git/nuget-trends/src/NuGetTrends.Data/NuGetTrends.Data.csproj (in 633 ms).
  1 of 4 projects are up-to-date for restore.
  NuGet.Protocol.Catalog -> /Users/bruno/git/nuget-trends/src/NuGet.Protocol.Catalog/bin/Debug/netstandard2.1/NuGet.Protocol.Catalog.dll
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.0.5/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'StructureMap.dll' at /Users/bruno/.nuget/packages/structuremap/4.4.0/lib/netstandard1.5/StructureMap.dll [/Users/bruno/git/nuget-trends/src/NuGetTrends.Data/NuGetTrends.Data.csproj]
  NuGetTrends.Data -> /Users/bruno/git/nuget-trends/src/NuGetTrends.Data/bin/Debug/net5.0/NuGetTrends.Data.dll
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.0.5/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'StructureMap.dll' at /Users/bruno/.nuget/packages/structuremap/4.4.0/lib/netstandard1.5/StructureMap.dll [/Users/bruno/git/nuget-trends/src/NuGetTrends.Scheduler/NuGetTrends.Scheduler.csproj]
/Users/bruno/.nuget/packages/unoptimizedassemblydetector/0.0.5/build/UnoptimizedAssemblyDetector.targets(14,5): warning : Unoptimized assembly detected: 'StructureMap.dll' at /Users/bruno/.nuget/packages/structuremap/4.4.0/lib/netstandard1.5/StructureMap.dll [/Users/bruno/git/nuget-trends/src/NuGetTrends.Web/NuGetTrends.Web.csproj]
  NuGetTrends.Scheduler -> /Users/bruno/git/nuget-trends/src/NuGetTrends.Scheduler/bin/Debug/net5.0/NuGetTrends.Scheduler.dll
  NuGetTrends.Web -> /Users/bruno/git/nuget-trends/src/NuGetTrends.Web/bin/Debug/net5.0/NuGetTrends.Web.dll
codecov[bot] commented 3 years ago

Codecov Report

Merging #151 (7e7c10d) into main (8c418e8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files          28       28           
  Lines         432      432           
  Branches       32       32           
=======================================
  Hits          393      393           
  Misses         29       29           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c418e8...7e7c10d. Read the comment docs.

joaopgrassi commented 3 years ago

This looks cool! :fire: