dotnet / nuget-trends

Check out NuGet packages adoption and what's trending on NuGet.
https://nugettrends.com
MIT License
144 stars 25 forks source link

package update and central management #252

Closed chr-ber closed 5 months ago

chr-ber commented 5 months ago

This pull request includes:

chr-ber commented 5 months ago

@dotnet-policy-service agree

bruno-garcia commented 5 months ago

Nice! Thanks @chr-ber

bruno-garcia commented 5 months ago

Dang didn't recognize you from the pic Chris! ;) this makes things a lot easier to manage packages, thanks

bruno-garcia commented 5 months ago

CI failed with

Error: src/app/app.module.ts:46:9 - error TS2322: Type '{ canvas: { fps: number; quality: number; manager: (options: PublicGetCanvasManagerOptions) => CanvasManagerInterface; }; }' is not assignable to type 'Partial<{ captureExceptions: boolean; traceInternals: boolean; }>'.
  Object literal may only specify known properties, and 'canvas' does not exist in type 'Partial<{ captureExceptions: boolean; traceInternals: boolean; }>'.

 46         canvas: {
            ~~~~~~~~~
 47           fps: 4,
    ~~~~~~~~~~~~~~~~~
... 
 49           manager: getCanvasManager,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 50         },
    ~~~~~~~~~

We changed some canvas stuff on the Sentry SDK but surprised this happened in CI since it should be pinned to the latest version.

I'll fix it on another PR