dotnet / nuget-trends

Check out NuGet packages adoption and what's trending on NuGet.
https://nugettrends.com
MIT License
144 stars 25 forks source link

feature/streamline logging and exception messages #257

Closed chr-ber closed 4 months ago

chr-ber commented 4 months ago

The most important aspect of this pull request is the addition of a missing string interpolation symbol to one of the log messages, found in the first commit -> https://github.com/dotnet/nuget-trends/commit/c50e6dafe343779b6537cc6a1a906ae052bd7fa3. I encountered this issue when running the project locally.

While I was at it, I also reviewed all log and exception messages in the project and unified their style. I understand if that seems a bit unnecessary; I guess I got carried away. 😅 I believe the first commit should be accepted at the very least. If the rest ends up in the 🗑️. No harm done!

In general, I tried to apply these simple rules:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c94f1a1) 93.24% compared to head (8805145) 93.24%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ======================================= Coverage 93.24% 93.24% ======================================= Files 27 27 Lines 429 429 Branches 33 33 ======================================= Hits 400 400 Misses 27 27 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bruno-garcia commented 4 months ago

Thanks again Chris!