dotnet / orleans

Cloud Native application framework for .NET
https://docs.microsoft.com/dotnet/orleans
MIT License
10.1k stars 2.04k forks source link

Configuration Work - unwanted or improperly organized settings #3957

Closed jason-bragg closed 6 years ago

jason-bragg commented 6 years ago

While moving from monolithic Cluster and Client configurations to options, settings surfaced which should probably not be part of Orleans core or may not be categorized correctly.

Below is a list of some such settings, and I encourage others to contribute to this list if the current options seem ill conceived or unnecessary.

AdoNetOptions - should not be in Orleans core. ServicePointOptions - should not be in Orleans core. Load shedding settings - Probably should not be part of statistics. (EDIT: moved to its own options) FastKillOnCancelKeyPress - probably should not be in Orleans core.

Figure out what to do about these.

[Edit] Thread pool options - don't think thread pool settup should be part of orleans core.

ReubenBond commented 6 years ago

Is this fixed now?

xiazen commented 6 years ago

fixed and can close now