search

dotnet / orleans

Cloud Native application framework for .NET
https://docs.microsoft.com/dotnet/orleans
MIT License
10.06k stars 2.03k forks source link

TestCluster may be broken with version 4.0.0-preview1 #7762

Closed jan-johansson-mr closed 1 year ago

jan-johansson-mr commented 2 years ago

Hi,

My unit tests do not work after upgrading to 4.0.0-preview1, and to illustrate what is happening, I've included a sample. The tests are working with version 3.6.2.

Thanks

jan-johansson-mr commented 2 years ago

Found out that using Microsoft.Orleans.Sdk and removing Microsoft.Orleans.CodeGenerator.MSBuild from the package references in the csproj file makes the sample work with 4.0.0-preview1.

ghost commented 2 years ago

We're moving this issue to the 4.0-Planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.

ReubenBond commented 2 years ago

Hi @jan-johansson-mr, do you think we need to do something here? Maybe we can try to disable the MSBuild code generator if the Microsoft.Orleans.CodeGenerator package is also installed (which is a C# Source Generator).

jan-johansson-mr commented 2 years ago

I think there is nothing really to do, except maybe as you say, to disable the MSBuild code generator, or putting in documentation as version 4.0.0 gets released. I like the SDK way of things.