dotnet / orleans

Cloud Native application framework for .NET
https://docs.microsoft.com/dotnet/orleans
MIT License
10.06k stars 2.03k forks source link

Implement `CleanupDefunctSiloEntries` for development clustering #8256

Open JaktensTid opened 1 year ago

JaktensTid commented 1 year ago

After about 10 mins of inactivity my code is always trying to execute the following code and throws the error

public Task CleanupDefunctSiloEntries(DateTimeOffset beforeDate)
        {
                throw new NotImplementedException();
        }

in SystemTargetBasedMembershipTable.cs

What is the reason of this?

My startup code

builder.Host.UseOrleans(silo =>
{
    silo
        .UseLocalhostClustering()
        .ConfigureLogging(options => options.SetMinimumLevel(LogLevel.Information))
        .AddIncomingGrainCallFilter<LoggingInterceptor>()
        .AddAdoNetGrainStorage(StateStorageConstants.StorageName, options =>
        {
            options.Invariant = "Npgsql";
            options.ConnectionString = builder.Configuration.GetConnectionString("postgres");
        });
});
ReubenBond commented 1 year ago

That error is benign. The "localhost clustering" is only intended for dev/test, so generally doesn't live long-enough to warrant cleaning up defunct silos.

Regardless, we should implement it.

ghost commented 1 year ago

We've moved this issue to the Backlog. This means that it is not going to be worked on for the coming release. We review items in the backlog at the end of each milestone/release and depending on the team's priority we may reconsider this issue for the following milestone.

ElanHasson commented 1 year ago

n/m i saw this was localhost clustering :D

sorry!