performanceautofiler[bot]
commented
1 year ago Run Information
| Architecture | x86 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | ff12237f483eb0afdabf1aeb71b69ff992d6bd40 |
| Compare | 7ec3634ee579d89b6024f72b595bfd7118093fc5 |
| Diff | Diff |
Regressions in System.Tests.Perf_DateTime
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| [ToString - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Tests.Perf_DateTime.ToString(format%3a%20null).html>) | 312.32 ns | 331.98 ns | 1.06 | 0.01 | False | 2676.3676615170957 | 2794.3935547952765 | 1.0440992823875619 | Trace | Trace |
| [ToString - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Tests.Perf_DateTime.ToString(format%3a%20%22G%22).html>) | 312.70 ns | 333.62 ns | 1.07 | 0.01 | False | 2665.4122745854015 | 2785.4452166006363 | 1.0450335368977415 | Trace | Trace |
Repro
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_DateTime*'
### Payloads
[Baseline]()
[Compare]()
### Histogram
#### System.Tests.Perf_DateTime.ToString(format: null)
```log
```
### Description of detection logic
```IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 331.98274237011583 > 328.15286936557794.
IsChangePoint: Marked as a change because one of 12/14/2022 12:01:27 PM, 1/13/2023 4:18:46 AM, 1/21/2023 1:51:00 AM, 1/24/2023 6:33:57 AM falls between 1/15/2023 4:08:29 PM and 1/24/2023 6:33:57 AM.
IsRegressionStdDev: Marked as regression because -23.14650179827211 (T) = (0 -335.7061065964193) / Math.Sqrt((7.543405320312097 / (51)) + (11.137237817482005 / (17))) is less than -1.9965644189515832 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (17) - 2, .025) and -0.06585572769051379 = (314.9639279265536 - 335.7061065964193) / 314.9639279265536 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Tests.Perf_DateTime.ToString(System.String)
push ebp
mov ebp,esp
sub esp,8
add ecx,8
mov eax,[ecx]
mov ecx,[ecx+4]
mov [ebp-8],eax
mov [ebp-4],ecx
push dword ptr [ebp-4]
push dword ptr [ebp-8]
push 80000000
push 0
mov ecx,edx
xor edx,edx
call dword ptr ds:[0AF19678]; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
mov esp,ebp
pop ebp
ret
; Total bytes of code 47
```
```assembly
; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
push ebp
mov ebp,esp
push edi
push esi
sub esp,28
vxorps xmm4,xmm4,xmm4
vmovdqu xmmword ptr [ebp-2C],xmm4
vmovdqu xmmword ptr [ebp-1C],xmm4
mov [ebp-0C],esp
mov dword ptr [ebp-30],13BFBE4A
mov eax,edx
test ecx,ecx
je short M01_L01
cmp dword ptr [ecx+4],1
jne short M01_L01
movzx edx,word ptr [ecx+8]
or edx,20
cmp edx,6F
je near ptr M01_L04
cmp edx,72
jne short M01_L01
mov ecx,1D
call System.String.FastAllocateString(Int32)
mov esi,eax
lea ecx,[esi+8]
mov eax,[esi+4]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push eax
push ecx
lea ecx,[ebp-24]
call dword ptr ds:[0AF19780]
mov eax,esi
cmp dword ptr [ebp-30],13BFBE4A
je short M01_L00
call CORINFO_HELP_FAIL_FAST
M01_L00:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L01:
test [esp],esp
sub esp,200
lea edx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],edx
mov dword ptr [ebp-28],100
mov edx,[ebp-2C]
mov esi,[ebp-28]
xor edi,edi
mov [ebp-1C],edi
mov [ebp-14],edx
mov [ebp-10],esi
mov [ebp-18],edi
test ecx,ecx
je near ptr M01_L06
lea edx,[ecx+8]
mov esi,[ecx+4]
M01_L02:
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push esi
push edx
mov ecx,eax
call dword ptr ds:[0A4838D0]; System.Globalization.DateTimeFormatInfo.GetInstance(System.IFormatProvider)
mov ecx,eax
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
lea edx,[ebp-1C]
call dword ptr ds:[0AF196C0]; System.DateTimeFormat.FormatStringBuilder(System.DateTime, System.ReadOnlySpan`1, System.Globalization.DateTimeFormatInfo, System.TimeSpan, System.Text.ValueStringBuilder ByRef)
lea ecx,[ebp-1C]
call dword ptr ds:[0AA69120]; System.Text.ValueStringBuilder.ToString()
cmp dword ptr [ebp-30],13BFBE4A
je short M01_L03
call CORINFO_HELP_FAIL_FAST
M01_L03:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L04:
test [esp],esp
sub esp,44
lea ecx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],ecx
mov dword ptr [ebp-28],21
mov esi,[ebp-2C]
mov edi,[ebp-28]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push edi
push esi
lea ecx,[ebp-20]
call dword ptr ds:[0AF19768]
mov ecx,[ebp-20]
cmp ecx,edi
ja short M01_L07
mov [ebp-2C],esi
mov [ebp-28],ecx
lea ecx,[ebp-2C]
call dword ptr ds:[83C7D08]; System.Span`1[[System.Char, System.Private.CoreLib]].ToString()
cmp dword ptr [ebp-30],13BFBE4A
je short M01_L05
call CORINFO_HELP_FAIL_FAST
M01_L05:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L06:
xor edx,edx
xor esi,esi
jmp near ptr M01_L02
M01_L07:
call dword ptr ds:[8485060]
int 3
; Total bytes of code 367
```
### Compare Jit Disasm
```assembly
; System.Tests.Perf_DateTime.ToString(System.String)
push ebp
mov ebp,esp
sub esp,8
add ecx,8
mov eax,[ecx]
mov ecx,[ecx+4]
mov [ebp-8],eax
mov [ebp-4],ecx
push dword ptr [ebp-4]
push dword ptr [ebp-8]
push 80000000
push 0
mov ecx,edx
xor edx,edx
call dword ptr ds:[0B779678]; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
mov esp,ebp
pop ebp
ret
; Total bytes of code 47
```
```assembly
; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
push ebp
mov ebp,esp
push edi
push esi
sub esp,28
vxorps xmm4,xmm4,xmm4
vmovdqu xmmword ptr [ebp-2C],xmm4
vmovdqu xmmword ptr [ebp-1C],xmm4
mov [ebp-0C],esp
mov dword ptr [ebp-30],68EC7A09
mov eax,edx
test ecx,ecx
je short M01_L01
cmp dword ptr [ecx+4],1
jne short M01_L01
movzx edx,word ptr [ecx+8]
or edx,20
cmp edx,6F
je near ptr M01_L04
cmp edx,72
jne short M01_L01
mov ecx,1D
call System.String.FastAllocateString(Int32)
mov esi,eax
lea ecx,[esi+8]
mov eax,[esi+4]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push eax
push ecx
lea ecx,[ebp-24]
call dword ptr ds:[0B779780]
mov eax,esi
cmp dword ptr [ebp-30],68EC7A09
je short M01_L00
call CORINFO_HELP_FAIL_FAST
M01_L00:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L01:
test [esp],esp
sub esp,200
lea edx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],edx
mov dword ptr [ebp-28],100
mov edx,[ebp-2C]
mov esi,[ebp-28]
xor edi,edi
mov [ebp-1C],edi
mov [ebp-14],edx
mov [ebp-10],esi
mov [ebp-18],edi
test ecx,ecx
je near ptr M01_L06
lea edx,[ecx+8]
mov esi,[ecx+4]
M01_L02:
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push esi
push edx
mov ecx,eax
call dword ptr ds:[0ACF51B0]; System.Globalization.DateTimeFormatInfo.GetInstance(System.IFormatProvider)
mov ecx,eax
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
lea edx,[ebp-1C]
call dword ptr ds:[0B7796C0]; System.DateTimeFormat.FormatStringBuilder(System.DateTime, System.ReadOnlySpan`1, System.Globalization.DateTimeFormatInfo, System.TimeSpan, System.Text.ValueStringBuilder ByRef)
lea ecx,[ebp-1C]
call dword ptr ds:[0B2C9120]; System.Text.ValueStringBuilder.ToString()
cmp dword ptr [ebp-30],68EC7A09
je short M01_L03
call CORINFO_HELP_FAIL_FAST
M01_L03:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L04:
test [esp],esp
sub esp,44
lea ecx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],ecx
mov dword ptr [ebp-28],21
mov esi,[ebp-2C]
mov edi,[ebp-28]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push edi
push esi
lea ecx,[ebp-20]
call dword ptr ds:[0B779768]
mov ecx,[ebp-20]
cmp ecx,edi
ja short M01_L07
mov [ebp-2C],esi
mov [ebp-28],ecx
lea ecx,[ebp-2C]
call dword ptr ds:[8C95C78]; System.Span`1[[System.Char, System.Private.CoreLib]].ToString()
cmp dword ptr [ebp-30],68EC7A09
je short M01_L05
call CORINFO_HELP_FAIL_FAST
M01_L05:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L06:
xor edx,edx
xor esi,esi
jmp near ptr M01_L02
M01_L07:
call dword ptr ds:[8D15060]
int 3
; Total bytes of code 367
```
#### System.Tests.Perf_DateTime.ToString(format: "G")
```log
```
### Description of detection logic
```IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 333.6245123022215 > 327.8472604097565.
IsChangePoint: Marked as a change because one of 12/14/2022 5:20:21 PM, 1/13/2023 4:18:46 AM, 1/21/2023 1:51:00 AM, 1/24/2023 6:33:57 AM falls between 1/15/2023 4:08:29 PM and 1/24/2023 6:33:57 AM.
IsRegressionStdDev: Marked as regression because -22.05363639781273 (T) = (0 -334.3628942443974) / Math.Sqrt((14.416789381587552 / (51)) + (8.605747805059638 / (17))) is less than -1.9965644189515832 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (17) - 2, .025) and -0.06222887227272771 = (314.7748126343054 - 334.3628942443974) / 314.7748126343054 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Tests.Perf_DateTime.ToString(System.String)
push ebp
mov ebp,esp
sub esp,8
add ecx,8
mov eax,[ecx]
mov ecx,[ecx+4]
mov [ebp-8],eax
mov [ebp-4],ecx
push dword ptr [ebp-4]
push dword ptr [ebp-8]
push 80000000
push 0
mov ecx,edx
xor edx,edx
call dword ptr ds:[0B739810]; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
mov esp,ebp
pop ebp
ret
; Total bytes of code 47
```
```assembly
; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
push ebp
mov ebp,esp
push edi
push esi
sub esp,28
vxorps xmm4,xmm4,xmm4
vmovdqu xmmword ptr [ebp-2C],xmm4
vmovdqu xmmword ptr [ebp-1C],xmm4
mov [ebp-0C],esp
mov dword ptr [ebp-30],5BE70082
mov eax,edx
test ecx,ecx
je short M01_L01
cmp dword ptr [ecx+4],1
jne short M01_L01
movzx edx,word ptr [ecx+8]
or edx,20
cmp edx,6F
je near ptr M01_L04
cmp edx,72
jne short M01_L01
mov ecx,1D
call System.String.FastAllocateString(Int32)
mov esi,eax
lea ecx,[esi+8]
mov eax,[esi+4]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push eax
push ecx
lea ecx,[ebp-24]
call dword ptr ds:[0B739918]
mov eax,esi
cmp dword ptr [ebp-30],5BE70082
je short M01_L00
call CORINFO_HELP_FAIL_FAST
M01_L00:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L01:
test [esp],esp
sub esp,200
lea edx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],edx
mov dword ptr [ebp-28],100
mov edx,[ebp-2C]
mov esi,[ebp-28]
xor edi,edi
mov [ebp-1C],edi
mov [ebp-14],edx
mov [ebp-10],esi
mov [ebp-18],edi
test ecx,ecx
je near ptr M01_L06
lea edx,[ecx+8]
mov esi,[ecx+4]
M01_L02:
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push esi
push edx
mov ecx,eax
call dword ptr ds:[0ACA38D0]; System.Globalization.DateTimeFormatInfo.GetInstance(System.IFormatProvider)
mov ecx,eax
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
lea edx,[ebp-1C]
call dword ptr ds:[0B739858]; System.DateTimeFormat.FormatStringBuilder(System.DateTime, System.ReadOnlySpan`1, System.Globalization.DateTimeFormatInfo, System.TimeSpan, System.Text.ValueStringBuilder ByRef)
lea ecx,[ebp-1C]
call dword ptr ds:[0B289120]; System.Text.ValueStringBuilder.ToString()
cmp dword ptr [ebp-30],5BE70082
je short M01_L03
call CORINFO_HELP_FAIL_FAST
M01_L03:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L04:
test [esp],esp
sub esp,44
lea ecx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],ecx
mov dword ptr [ebp-28],21
mov esi,[ebp-2C]
mov edi,[ebp-28]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push edi
push esi
lea ecx,[ebp-20]
call dword ptr ds:[0B739900]
mov ecx,[ebp-20]
cmp ecx,edi
ja short M01_L07
mov [ebp-2C],esi
mov [ebp-28],ecx
lea ecx,[ebp-2C]
call dword ptr ds:[8BE7D08]; System.Span`1[[System.Char, System.Private.CoreLib]].ToString()
cmp dword ptr [ebp-30],5BE70082
je short M01_L05
call CORINFO_HELP_FAIL_FAST
M01_L05:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L06:
xor edx,edx
xor esi,esi
jmp near ptr M01_L02
M01_L07:
call dword ptr ds:[8CA5060]
int 3
; Total bytes of code 367
```
### Compare Jit Disasm
```assembly
; System.Tests.Perf_DateTime.ToString(System.String)
push ebp
mov ebp,esp
sub esp,8
add ecx,8
mov eax,[ecx]
mov ecx,[ecx+4]
mov [ebp-8],eax
mov [ebp-4],ecx
push dword ptr [ebp-4]
push dword ptr [ebp-8]
push 80000000
push 0
mov ecx,edx
xor edx,edx
call dword ptr ds:[0AEB9810]; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
mov esp,ebp
pop ebp
ret
; Total bytes of code 47
```
```assembly
; System.DateTimeFormat.Format(System.DateTime, System.String, System.IFormatProvider, System.TimeSpan)
push ebp
mov ebp,esp
push edi
push esi
sub esp,28
vxorps xmm4,xmm4,xmm4
vmovdqu xmmword ptr [ebp-2C],xmm4
vmovdqu xmmword ptr [ebp-1C],xmm4
mov [ebp-0C],esp
mov dword ptr [ebp-30],606E9C75
mov eax,edx
test ecx,ecx
je short M01_L01
cmp dword ptr [ecx+4],1
jne short M01_L01
movzx edx,word ptr [ecx+8]
or edx,20
cmp edx,6F
je near ptr M01_L04
cmp edx,72
jne short M01_L01
mov ecx,1D
call System.String.FastAllocateString(Int32)
mov esi,eax
lea ecx,[esi+8]
mov eax,[esi+4]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push eax
push ecx
lea ecx,[ebp-24]
call dword ptr ds:[0AEB9918]
mov eax,esi
cmp dword ptr [ebp-30],606E9C75
je short M01_L00
call CORINFO_HELP_FAIL_FAST
M01_L00:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L01:
test [esp],esp
sub esp,200
lea edx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],edx
mov dword ptr [ebp-28],100
mov edx,[ebp-2C]
mov esi,[ebp-28]
xor edi,edi
mov [ebp-1C],edi
mov [ebp-14],edx
mov [ebp-10],esi
mov [ebp-18],edi
test ecx,ecx
je near ptr M01_L06
lea edx,[ecx+8]
mov esi,[ecx+4]
M01_L02:
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push esi
push edx
mov ecx,eax
call dword ptr ds:[0A4351B0]; System.Globalization.DateTimeFormatInfo.GetInstance(System.IFormatProvider)
mov ecx,eax
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
lea edx,[ebp-1C]
call dword ptr ds:[0AEB9858]; System.DateTimeFormat.FormatStringBuilder(System.DateTime, System.ReadOnlySpan`1, System.Globalization.DateTimeFormatInfo, System.TimeSpan, System.Text.ValueStringBuilder ByRef)
lea ecx,[ebp-1C]
call dword ptr ds:[0AA09120]; System.Text.ValueStringBuilder.ToString()
cmp dword ptr [ebp-30],606E9C75
je short M01_L03
call CORINFO_HELP_FAIL_FAST
M01_L03:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L04:
test [esp],esp
sub esp,44
lea ecx,[esp]
mov [ebp-0C],esp
mov [ebp-2C],ecx
mov dword ptr [ebp-28],21
mov esi,[ebp-2C]
mov edi,[ebp-28]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push edi
push esi
lea ecx,[ebp-20]
call dword ptr ds:[0AEB9900]
mov ecx,[ebp-20]
cmp ecx,edi
ja short M01_L07
mov [ebp-2C],esi
mov [ebp-28],ecx
lea ecx,[ebp-2C]
call dword ptr ds:[83D5C78]; System.Span`1[[System.Char, System.Private.CoreLib]].ToString()
cmp dword ptr [ebp-30],606E9C75
je short M01_L05
call CORINFO_HELP_FAIL_FAST
M01_L05:
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 10
M01_L06:
xor edx,edx
xor esi,esi
jmp near ptr M01_L02
M01_L07:
call dword ptr ds:[8455060]
int 3
; Total bytes of code 367
```
### Docs
[Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md)
[Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
Run Information
Regressions in System.Globalization.Tests.Perf_DateTimeCultureInfo
Repro