performanceautofiler[bot]
commented
1 year ago Run Information
| Architecture | x86 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | ff12237f483eb0afdabf1aeb71b69ff992d6bd40 |
| Compare | 7ec3634ee579d89b6024f72b595bfd7118093fc5 |
| Diff | Diff |
Improvements in System.Text.RegularExpressions.Tests.Perf_Regex_Common
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| [CtorInvoke - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke(Options%3a%20IgnoreCase%2c%20Compiled).html>) | 334.90 μs | 306.96 μs | 0.92 | 0.00 | False | 1373495.3703703703 | 1127876.9841269841 | 0.8211727599947032 | Trace | Trace |
| [CtorInvoke - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke(Options%3a%20Compiled).html>) | 312.32 μs | 287.70 μs | 0.92 | 0.00 | False | 1323198.1981981983 | 1071590.9090909092 | 0.8098491295938104 | Trace | Trace |
Repro
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Common*'
### Payloads
[Baseline]()
[Compare]()
### Histogram
#### System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke(Options: IgnoreCase, Compiled)
```log
```
### Description of detection logic
```IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 306.95784474671666 < 316.1582059459237.
IsChangePoint: Marked as a change because one of 1/21/2023 1:51:00 AM, 1/24/2023 6:33:57 AM falls between 1/15/2023 4:08:29 PM and 1/24/2023 6:33:57 AM.
IsImprovementStdDev: Marked as improvement because 41.01012376213385 (T) = (0 -308966.85268674383) / Math.Sqrt((5194819.821356694 / (299)) + (5934124.659634094 / (17))) is greater than 1.9675476980854363 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (17) - 2, .975) and 0.07437322554614835 = (333792.0436334005 - 308966.85268674383) / 333792.0436334005 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke()
push ebp
mov ebp,esp
push edi
push esi
mov esi,ecx
mov ecx,offset MT_System.Text.RegularExpressions.Regex
call CORINFO_HELP_NEWSFAST
mov edi,eax
push dword ptr [esi+30]
mov ecx,edi
mov edx,7C4E628
call dword ptr ds:[0A8893C0]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
mov ecx,edi
test byte ptr [ecx+20],40
jne short M00_L00
xor edx,edx
jmp short M00_L01
M00_L00:
mov edx,2
M00_L01:
push 0FFFFFFFF
push 7C4E6C4
push 0
push 2
push edx
xor edx,edx
call dword ptr ds:[0A889678]; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
pop esi
pop edi
pop ebp
ret
; Total bytes of code 76
```
```assembly
; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
push ebp
mov ebp,esp
push dword ptr [ebp+8]
mov eax,ds:[69E4D28]
add eax,4
push dword ptr [eax+4]
push dword ptr [eax]
push 0
call dword ptr ds:[0A889408]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions, System.TimeSpan, System.Globalization.CultureInfo)
pop ebp
ret 4
; Total bytes of code 31
```
```assembly
; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,30
xor eax,eax
mov [ebp-30],eax
mov [ebp-34],eax
mov [ebp-18],eax
mov [ebp-2C],ecx
mov esi,edx
mov ebx,[ebp+14]
mov edi,[ebp+10]
mov [ebp+14],ebx
mov edx,[ebx+4]
mov [ebp-28],edx
mov eax,[ebp+8]
cmp edx,eax
jb near ptr M02_L14
mov eax,[ebp+0C]
cmp edx,eax
jb near ptr M02_L15
cmp [ecx],cl
lea eax,[ecx+1C]
xor ebx,ebx
xchg ebx,[eax]
test ebx,ebx
jne short M02_L00
mov eax,[ecx+8]
mov ecx,eax
mov eax,[eax]
mov eax,[eax+28]
call dword ptr [eax+10]
mov ebx,eax
mov ecx,[ebp-2C]
M02_L00:
mov [ebp-30],ebx
lea eax,[ecx+2C]
push dword ptr [eax+4]
push dword ptr [eax]
mov ecx,ebx
cmp [ecx],ecx
call dword ptr ds:[0AD1F8A0]; System.Text.RegularExpressions.RegexRunner.InitializeTimeout(System.TimeSpan)
lea edx,[ebx+0C]
mov eax,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_EAX
mov ecx,[ebp-28]
cmp ecx,edi
jb near ptr M02_L08
sub ecx,edi
mov edx,[ebp+0C]
cmp ecx,edx
jb near ptr M02_L08
mov [ebp+14],eax
lea ecx,[eax+edi*2+8]
mov [ebp-3C],ecx
mov [ebp-24],edx
push edx
push ecx
mov eax,[ebp+8]
sub eax,edi
push eax
push esi
mov ecx,ebx
mov edx,[ebp-2C]
call dword ptr ds:[0AD1F888]; System.Text.RegularExpressions.RegexRunner.InitializeForScan(System.Text.RegularExpressions.Regex, System.ReadOnlySpan`1, Int32, System.Text.RegularExpressions.RegexRunnerMode)
cmp dword ptr [ebp+18],0
jne short M02_L03
mov ecx,[ebp-24]
mov eax,ecx
mov edx,1
mov ecx,[ebp-2C]
test byte ptr [ecx+20],40
je short M02_L01
xor eax,eax
mov edx,0FFFFFFFF
M02_L01:
cmp [ebx+2C],eax
jne short M02_L02
mov edx,ds:[69E4D20]
mov [ebp-34],edx
mov dword ptr [ebp-1C],0
mov dword ptr [ebp-18],0FC
push offset M02_L11
jmp near ptr M02_L12
M02_L02:
add [ebx+30],edx
M02_L03:
push dword ptr [ebp-24]
push dword ptr [ebp-3C]
mov ecx,ebx
mov eax,[ebx]
mov eax,[eax+28]
call dword ptr [eax+10]
mov eax,[ebx+1C]
mov [ebp-38],eax
mov edx,[eax+2C]
cmp dword ptr [edx+4],0
jbe short M02_L04
cmp dword ptr [edx+8],0
jle short M02_L09
test esi,esi
je short M02_L05
lea edx,[eax+4]
mov ecx,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_ECX
xor edx,edx
mov [ebx+1C],edx
jmp short M02_L06
M02_L04:
call CORINFO_HELP_RNGCHKFAIL
M02_L05:
xor edx,edx
mov [eax+4],edx
jmp short M02_L07
M02_L06:
mov edx,[ebx+30]
push edi
push esi
mov ecx,eax
call dword ptr ds:[0B459AB0]
mov esi,[ebp-38]
mov edx,esi
M02_L07:
mov [ebp-34],edx
jmp short M02_L10
M02_L08:
mov ecx,21
call dword ptr ds:[82D53A8]
int 3
M02_L09:
xor edx,edx
mov [eax+4],edx
mov edx,ds:[69E4D20]
jmp short M02_L07
M02_L10:
xor edx,edx
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
jmp short M02_L13
M02_L11:
mov dword ptr [ebp-18],0
jmp short M02_L13
M02_L12:
xor edx,edx
mov ebx,[ebp-30]
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
pop eax
jmp eax
M02_L13:
mov eax,[ebp-34]
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret 14
M02_L14:
mov ecx,0E
xor edx,edx
call dword ptr ds:[0ACEBD68]
int 3
M02_L15:
mov ecx,8
mov edx,2
call dword ptr ds:[0ACEBD68]
int 3
; Total bytes of code 467
```
### Compare Jit Disasm
```assembly
; System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke()
push ebp
mov ebp,esp
push edi
push esi
mov esi,ecx
mov ecx,offset MT_System.Text.RegularExpressions.Regex
call CORINFO_HELP_NEWSFAST
mov edi,eax
push dword ptr [esi+30]
mov ecx,edi
mov edx,874E628
call dword ptr ds:[0B3793C0]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
mov ecx,edi
test byte ptr [ecx+20],40
jne short M00_L00
xor edx,edx
jmp short M00_L01
M00_L00:
mov edx,2
M00_L01:
push 0FFFFFFFF
push 874E6C4
push 0
push 2
push edx
xor edx,edx
call dword ptr ds:[0B379678]; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
pop esi
pop edi
pop ebp
ret
; Total bytes of code 76
```
```assembly
; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
push ebp
mov ebp,esp
push dword ptr [ebp+8]
mov eax,ds:[75C4D28]
add eax,4
push dword ptr [eax+4]
push dword ptr [eax]
push 0
call dword ptr ds:[0B379408]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions, System.TimeSpan, System.Globalization.CultureInfo)
pop ebp
ret 4
; Total bytes of code 31
```
```assembly
; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,30
xor eax,eax
mov [ebp-30],eax
mov [ebp-34],eax
mov [ebp-18],eax
mov [ebp-2C],ecx
mov esi,edx
mov ebx,[ebp+14]
mov edi,[ebp+10]
mov [ebp+14],ebx
mov edx,[ebx+4]
mov [ebp-28],edx
mov eax,[ebp+8]
cmp edx,eax
jb near ptr M02_L14
mov eax,[ebp+0C]
cmp edx,eax
jb near ptr M02_L15
cmp [ecx],cl
lea eax,[ecx+1C]
xor ebx,ebx
xchg ebx,[eax]
test ebx,ebx
jne short M02_L00
mov eax,[ecx+8]
mov ecx,eax
mov eax,[eax]
mov eax,[eax+28]
call dword ptr [eax+10]
mov ebx,eax
mov ecx,[ebp-2C]
M02_L00:
mov [ebp-30],ebx
lea eax,[ecx+2C]
push dword ptr [eax+4]
push dword ptr [eax]
mov ecx,ebx
cmp [ecx],ecx
call dword ptr ds:[0B80F8A0]; System.Text.RegularExpressions.RegexRunner.InitializeTimeout(System.TimeSpan)
lea edx,[ebx+0C]
mov eax,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_EAX
mov ecx,[ebp-28]
cmp ecx,edi
jb near ptr M02_L08
sub ecx,edi
mov edx,[ebp+0C]
cmp ecx,edx
jb near ptr M02_L08
mov [ebp+14],eax
lea ecx,[eax+edi*2+8]
mov [ebp-3C],ecx
mov [ebp-24],edx
push edx
push ecx
mov eax,[ebp+8]
sub eax,edi
push eax
push esi
mov ecx,ebx
mov edx,[ebp-2C]
call dword ptr ds:[0B80F888]; System.Text.RegularExpressions.RegexRunner.InitializeForScan(System.Text.RegularExpressions.Regex, System.ReadOnlySpan`1, Int32, System.Text.RegularExpressions.RegexRunnerMode)
cmp dword ptr [ebp+18],0
jne short M02_L03
mov ecx,[ebp-24]
mov eax,ecx
mov edx,1
mov ecx,[ebp-2C]
test byte ptr [ecx+20],40
je short M02_L01
xor eax,eax
mov edx,0FFFFFFFF
M02_L01:
cmp [ebx+2C],eax
jne short M02_L02
mov edx,ds:[75C4D20]
mov [ebp-34],edx
mov dword ptr [ebp-1C],0
mov dword ptr [ebp-18],0FC
push offset M02_L11
jmp near ptr M02_L12
M02_L02:
add [ebx+30],edx
M02_L03:
push dword ptr [ebp-24]
push dword ptr [ebp-3C]
mov ecx,ebx
mov eax,[ebx]
mov eax,[eax+28]
call dword ptr [eax+10]
mov eax,[ebx+1C]
mov [ebp-38],eax
mov edx,[eax+2C]
cmp dword ptr [edx+4],0
jbe short M02_L04
cmp dword ptr [edx+8],0
jle short M02_L09
test esi,esi
je short M02_L05
lea edx,[eax+4]
mov ecx,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_ECX
xor edx,edx
mov [ebx+1C],edx
jmp short M02_L06
M02_L04:
call CORINFO_HELP_RNGCHKFAIL
M02_L05:
xor edx,edx
mov [eax+4],edx
jmp short M02_L07
M02_L06:
mov edx,[ebx+30]
push edi
push esi
mov ecx,eax
call dword ptr ds:[0BF07C18]
mov esi,[ebp-38]
mov edx,esi
M02_L07:
mov [ebp-34],edx
jmp short M02_L10
M02_L08:
mov ecx,21
call dword ptr ds:[8DE53A8]
int 3
M02_L09:
xor edx,edx
mov [eax+4],edx
mov edx,ds:[75C4D20]
jmp short M02_L07
M02_L10:
xor edx,edx
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
jmp short M02_L13
M02_L11:
mov dword ptr [ebp-18],0
jmp short M02_L13
M02_L12:
xor edx,edx
mov ebx,[ebp-30]
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
pop eax
jmp eax
M02_L13:
mov eax,[ebp-34]
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret 14
M02_L14:
mov ecx,0E
xor edx,edx
call dword ptr ds:[0B7FBD68]
int 3
M02_L15:
mov ecx,8
mov edx,2
call dword ptr ds:[0B7FBD68]
int 3
; Total bytes of code 467
```
#### System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke(Options: Compiled)
```log
```
### Description of detection logic
```IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 287.6967669753087 < 297.95614865451387.
IsChangePoint: Marked as a change because one of 1/21/2023 1:51:00 AM, 1/24/2023 6:33:57 AM falls between 1/15/2023 4:08:29 PM and 1/24/2023 6:33:57 AM.
IsImprovementStdDev: Marked as improvement because 47.74031287495516 (T) = (0 -289483.24685865216) / Math.Sqrt((6062076.127456782 / (299)) + (3166939.396548353 / (17))) is greater than 1.9675476980854363 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (17) - 2, .975) and 0.06972695345356363 = (311180.94621072314 - 289483.24685865216) / 311180.94621072314 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke()
push ebp
mov ebp,esp
push edi
push esi
mov esi,ecx
mov ecx,offset MT_System.Text.RegularExpressions.Regex
call CORINFO_HELP_NEWSFAST
mov edi,eax
push dword ptr [esi+30]
mov ecx,edi
mov edx,875E600
call dword ptr ds:[0B3993C0]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
mov ecx,edi
test byte ptr [ecx+20],40
jne short M00_L00
xor edx,edx
jmp short M00_L01
M00_L00:
mov edx,2
M00_L01:
push 0FFFFFFFF
push 875E69C
push 0
push 2
push edx
xor edx,edx
call dword ptr ds:[0B399678]; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
pop esi
pop edi
pop ebp
ret
; Total bytes of code 76
```
```assembly
; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
push ebp
mov ebp,esp
push dword ptr [ebp+8]
mov eax,ds:[75D4D28]
add eax,4
push dword ptr [eax+4]
push dword ptr [eax]
push 0
call dword ptr ds:[0B399408]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions, System.TimeSpan, System.Globalization.CultureInfo)
pop ebp
ret 4
; Total bytes of code 31
```
```assembly
; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,30
xor eax,eax
mov [ebp-30],eax
mov [ebp-34],eax
mov [ebp-18],eax
mov [ebp-2C],ecx
mov esi,edx
mov ebx,[ebp+14]
mov edi,[ebp+10]
mov [ebp+14],ebx
mov edx,[ebx+4]
mov [ebp-28],edx
mov eax,[ebp+8]
cmp edx,eax
jb near ptr M02_L14
mov eax,[ebp+0C]
cmp edx,eax
jb near ptr M02_L15
cmp [ecx],cl
lea eax,[ecx+1C]
xor ebx,ebx
xchg ebx,[eax]
test ebx,ebx
jne short M02_L00
mov eax,[ecx+8]
mov ecx,eax
mov eax,[eax]
mov eax,[eax+28]
call dword ptr [eax+10]
mov ebx,eax
mov ecx,[ebp-2C]
M02_L00:
mov [ebp-30],ebx
lea eax,[ecx+2C]
push dword ptr [eax+4]
push dword ptr [eax]
mov ecx,ebx
cmp [ecx],ecx
call dword ptr ds:[0B82D9F0]; System.Text.RegularExpressions.RegexRunner.InitializeTimeout(System.TimeSpan)
lea edx,[ebx+0C]
mov eax,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_EAX
mov ecx,[ebp-28]
cmp ecx,edi
jb near ptr M02_L08
sub ecx,edi
mov edx,[ebp+0C]
cmp ecx,edx
jb near ptr M02_L08
mov [ebp+14],eax
lea ecx,[eax+edi*2+8]
mov [ebp-3C],ecx
mov [ebp-24],edx
push edx
push ecx
mov eax,[ebp+8]
sub eax,edi
push eax
push esi
mov ecx,ebx
mov edx,[ebp-2C]
call dword ptr ds:[0B82D9D8]; System.Text.RegularExpressions.RegexRunner.InitializeForScan(System.Text.RegularExpressions.Regex, System.ReadOnlySpan`1, Int32, System.Text.RegularExpressions.RegexRunnerMode)
cmp dword ptr [ebp+18],0
jne short M02_L03
mov ecx,[ebp-24]
mov eax,ecx
mov edx,1
mov ecx,[ebp-2C]
test byte ptr [ecx+20],40
je short M02_L01
xor eax,eax
mov edx,0FFFFFFFF
M02_L01:
cmp [ebx+2C],eax
jne short M02_L02
mov edx,ds:[75D4D20]
mov [ebp-34],edx
mov dword ptr [ebp-1C],0
mov dword ptr [ebp-18],0FC
push offset M02_L11
jmp near ptr M02_L12
M02_L02:
add [ebx+30],edx
M02_L03:
push dword ptr [ebp-24]
push dword ptr [ebp-3C]
mov ecx,ebx
mov eax,[ebx]
mov eax,[eax+28]
call dword ptr [eax+10]
mov eax,[ebx+1C]
mov [ebp-38],eax
mov edx,[eax+2C]
cmp dword ptr [edx+4],0
jbe short M02_L04
cmp dword ptr [edx+8],0
jle short M02_L09
test esi,esi
je short M02_L05
lea edx,[eax+4]
mov ecx,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_ECX
xor edx,edx
mov [ebx+1C],edx
jmp short M02_L06
M02_L04:
call CORINFO_HELP_RNGCHKFAIL
M02_L05:
xor edx,edx
mov [eax+4],edx
jmp short M02_L07
M02_L06:
mov edx,[ebx+30]
push edi
push esi
mov ecx,eax
call dword ptr ds:[0BF87210]
mov esi,[ebp-38]
mov edx,esi
M02_L07:
mov [ebp-34],edx
jmp short M02_L10
M02_L08:
mov ecx,21
call dword ptr ds:[8DE53A8]
int 3
M02_L09:
xor edx,edx
mov [eax+4],edx
mov edx,ds:[75D4D20]
jmp short M02_L07
M02_L10:
xor edx,edx
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
jmp short M02_L13
M02_L11:
mov dword ptr [ebp-18],0
jmp short M02_L13
M02_L12:
xor edx,edx
mov ebx,[ebp-30]
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
pop eax
jmp eax
M02_L13:
mov eax,[ebp-34]
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret 14
M02_L14:
mov ecx,0E
xor edx,edx
call dword ptr ds:[0B7FBD68]
int 3
M02_L15:
mov ecx,8
mov edx,2
call dword ptr ds:[0B7FBD68]
int 3
; Total bytes of code 467
```
### Compare Jit Disasm
```assembly
; System.Text.RegularExpressions.Tests.Perf_Regex_Common.CtorInvoke()
push ebp
mov ebp,esp
push edi
push esi
mov esi,ecx
mov ecx,offset MT_System.Text.RegularExpressions.Regex
call CORINFO_HELP_NEWSFAST
mov edi,eax
push dword ptr [esi+30]
mov ecx,edi
mov edx,8ADE600
call dword ptr ds:[0B7293C0]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
mov ecx,edi
test byte ptr [ecx+20],40
jne short M00_L00
xor edx,edx
jmp short M00_L01
M00_L00:
mov edx,2
M00_L01:
push 0FFFFFFFF
push 8ADE69C
push 0
push 2
push edx
xor edx,edx
call dword ptr ds:[0B729678]; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
pop esi
pop edi
pop ebp
ret
; Total bytes of code 76
```
```assembly
; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions)
push ebp
mov ebp,esp
push dword ptr [ebp+8]
mov eax,ds:[7774D28]
add eax,4
push dword ptr [eax+4]
push dword ptr [eax]
push 0
call dword ptr ds:[0B729408]; System.Text.RegularExpressions.Regex..ctor(System.String, System.Text.RegularExpressions.RegexOptions, System.TimeSpan, System.Globalization.CultureInfo)
pop ebp
ret 4
; Total bytes of code 31
```
```assembly
; System.Text.RegularExpressions.Regex.RunSingleMatch(System.Text.RegularExpressions.RegexRunnerMode, Int32, System.String, Int32, Int32, Int32)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,30
xor eax,eax
mov [ebp-30],eax
mov [ebp-34],eax
mov [ebp-18],eax
mov [ebp-2C],ecx
mov esi,edx
mov ebx,[ebp+14]
mov edi,[ebp+10]
mov [ebp+14],ebx
mov edx,[ebx+4]
mov [ebp-28],edx
mov eax,[ebp+8]
cmp edx,eax
jb near ptr M02_L14
mov eax,[ebp+0C]
cmp edx,eax
jb near ptr M02_L15
cmp [ecx],cl
lea eax,[ecx+1C]
xor ebx,ebx
xchg ebx,[eax]
test ebx,ebx
jne short M02_L00
mov eax,[ecx+8]
mov ecx,eax
mov eax,[eax]
mov eax,[eax+28]
call dword ptr [eax+10]
mov ebx,eax
mov ecx,[ebp-2C]
M02_L00:
mov [ebp-30],ebx
lea eax,[ecx+2C]
push dword ptr [eax+4]
push dword ptr [eax]
mov ecx,ebx
cmp [ecx],ecx
call dword ptr ds:[0BBBF8A0]; System.Text.RegularExpressions.RegexRunner.InitializeTimeout(System.TimeSpan)
lea edx,[ebx+0C]
mov eax,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_EAX
mov ecx,[ebp-28]
cmp ecx,edi
jb near ptr M02_L08
sub ecx,edi
mov edx,[ebp+0C]
cmp ecx,edx
jb near ptr M02_L08
mov [ebp+14],eax
lea ecx,[eax+edi*2+8]
mov [ebp-3C],ecx
mov [ebp-24],edx
push edx
push ecx
mov eax,[ebp+8]
sub eax,edi
push eax
push esi
mov ecx,ebx
mov edx,[ebp-2C]
call dword ptr ds:[0BBBF888]; System.Text.RegularExpressions.RegexRunner.InitializeForScan(System.Text.RegularExpressions.Regex, System.ReadOnlySpan`1, Int32, System.Text.RegularExpressions.RegexRunnerMode)
cmp dword ptr [ebp+18],0
jne short M02_L03
mov ecx,[ebp-24]
mov eax,ecx
mov edx,1
mov ecx,[ebp-2C]
test byte ptr [ecx+20],40
je short M02_L01
xor eax,eax
mov edx,0FFFFFFFF
M02_L01:
cmp [ebx+2C],eax
jne short M02_L02
mov edx,ds:[7774D20]
mov [ebp-34],edx
mov dword ptr [ebp-1C],0
mov dword ptr [ebp-18],0FC
push offset M02_L11
jmp near ptr M02_L12
M02_L02:
add [ebx+30],edx
M02_L03:
push dword ptr [ebp-24]
push dword ptr [ebp-3C]
mov ecx,ebx
mov eax,[ebx]
mov eax,[eax+28]
call dword ptr [eax+10]
mov eax,[ebx+1C]
mov [ebp-38],eax
mov edx,[eax+2C]
cmp dword ptr [edx+4],0
jbe short M02_L04
cmp dword ptr [edx+8],0
jle short M02_L09
test esi,esi
je short M02_L05
lea edx,[eax+4]
mov ecx,[ebp+14]
call CORINFO_HELP_ASSIGN_REF_ECX
xor edx,edx
mov [ebx+1C],edx
jmp short M02_L06
M02_L04:
call CORINFO_HELP_RNGCHKFAIL
M02_L05:
xor edx,edx
mov [eax+4],edx
jmp short M02_L07
M02_L06:
mov edx,[ebx+30]
push edi
push esi
mov ecx,eax
call dword ptr ds:[0C2F7210]
mov esi,[ebp-38]
mov edx,esi
M02_L07:
mov [ebp-34],edx
jmp short M02_L10
M02_L08:
mov ecx,21
call dword ptr ds:[91953A8]
int 3
M02_L09:
xor edx,edx
mov [eax+4],edx
mov edx,ds:[7774D20]
jmp short M02_L07
M02_L10:
xor edx,edx
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
jmp short M02_L13
M02_L11:
mov dword ptr [ebp-18],0
jmp short M02_L13
M02_L12:
xor edx,edx
mov ebx,[ebp-30]
mov [ebx+0C],edx
mov ecx,[ebp-2C]
lea edx,[ecx+1C]
call CORINFO_HELP_ASSIGN_REF_EBX
pop eax
jmp eax
M02_L13:
mov eax,[ebp-34]
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret 14
M02_L14:
mov ecx,0E
xor edx,edx
call dword ptr ds:[0BBABD68]
int 3
M02_L15:
mov ecx,8
mov edx,2
call dword ptr ds:[0BBABD68]
int 3
; Total bytes of code 467
```
### Docs
[Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md)
[Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
Run Information
| Architecture | x86 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | ff12237f483eb0afdabf1aeb71b69ff992d6bd40 |
| Compare | 7ec3634ee579d89b6024f72b595bfd7118093fc5 |
| Diff | Diff |
Improvements in System.Tests.Perf_UInt64
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| [TryFormat - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Tests.Perf_UInt64.TryFormat(value%3a%2012345).html>) | 11.25 ns | 9.15 ns | 0.81 | 0.04 | False | Trace | Trace |
Repro
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_UInt64*'
### Payloads
[Baseline]()
[Compare]()
### Histogram
#### System.Tests.Perf_UInt64.TryFormat(value: 12345)
```log
```
### Description of detection logic
```IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 9.15111347521668 < 9.990810818006207.
IsChangePoint: Marked as a change because one of 1/21/2023 1:51:00 AM, 1/24/2023 6:33:57 AM falls between 1/15/2023 4:08:29 PM and 1/24/2023 6:33:57 AM.
IsImprovementStdDev: Marked as improvement because 57.57265603900669 (T) = (0 -9.087681509308522) / Math.Sqrt((0.02288495923271687 / (299)) + (0.009194961509684215 / (17))) is greater than 1.9675476980854363 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (17) - 2, .975) and 0.13600751922073193 = (10.518241433203206 - 9.087681509308522) / 10.518241433203206 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Tests.Perf_UInt64.TryFormat(UInt64)
push ebp
mov ebp,esp
push edi
push esi
push eax
xor eax,eax
mov [ebp-0C],eax
mov ecx,[ecx+4]
test ecx,ecx
je short M00_L01
lea esi,[ecx+8]
mov edi,[ecx+4]
M00_L00:
mov ecx,[ebp+8]
mov eax,[ebp+0C]
push eax
push ecx
push edi
push esi
lea ecx,[ebp-0C]
call dword ptr ds:[8CDBA08]; System.Number.TryUInt64ToDecStr(UInt64, System.Span`1, Int32 ByRef)
pop ecx
pop esi
pop edi
pop ebp
ret 8
M00_L01:
xor esi,esi
xor edi,edi
jmp short M00_L00
; Total bytes of code 56
```
```assembly
; System.Number.TryUInt64ToDecStr(UInt64, System.Span`1, Int32 ByRef)
push ebp
mov ebp,esp
push esi
push eax
xor eax,eax
mov [ebp-8],eax
mov eax,5CBE261C
mov edx,[ebp+10]
mov esi,[ebp+14]
or edx,1
or esi,0
jne short M01_L00
or edx,1
lzcnt edx,edx
xor edx,1F
jmp short M01_L01
M01_L00:
or esi,1
xor edx,edx
lzcnt edx,esi
xor edx,1F
add edx,20
M01_L01:
movzx eax,byte ptr [eax+edx]
lea edx,[eax*8+5CBE872C]
mov esi,[edx]
mov edx,[edx+4]
cmp [ebp+10],esi
mov esi,[ebp+14]
sbb esi,edx
setb dl
movzx edx,dl
sub eax,edx
cmp eax,[ebp+0C]
jg short M01_L02
mov [ecx],eax
mov ecx,[ebp+8]
mov [ebp-8],ecx
lea ecx,[ecx+eax*2]
push dword ptr [ebp+14]
push dword ptr [ebp+10]
call dword ptr ds:[8CDB9A8]; System.Number.UInt64ToDecChars(Char*, UInt64)
xor eax,eax
mov [ebp-8],eax
mov eax,1
pop ecx
pop esi
pop ebp
ret 10
M01_L02:
xor eax,eax
mov [ecx],eax
pop ecx
pop esi
pop ebp
ret 10
; Total bytes of code 142
```
### Compare Jit Disasm
```assembly
; System.Tests.Perf_UInt64.TryFormat(UInt64)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C
xor eax,eax
mov [ebp-10],eax
mov [ebp-14],eax
mov ecx,[ecx+4]
test ecx,ecx
je near ptr M00_L05
lea esi,[ecx+8]
mov edi,[ecx+4]
M00_L00:
mov ecx,[ebp+8]
mov eax,[ebp+0C]
mov [ebp-18],esi
mov edx,6B8A164C
mov ebx,ecx
or ebx,1
mov esi,eax
or esi,0
jne short M00_L01
or ebx,1
lzcnt ebx,ebx
xor ebx,1F
jmp short M00_L02
M00_L01:
or esi,1
xor ebx,ebx
lzcnt ebx,esi
xor ebx,1F
add ebx,20
M00_L02:
movzx edx,byte ptr [edx+ebx]
lea esi,[edx*8+6B8A7FD8]
mov ebx,[esi]
mov esi,[esi+4]
cmp ecx,ebx
mov ebx,eax
sbb ebx,esi
setb bl
movzx ebx,bl
sub edx,ebx
cmp edx,edi
jg short M00_L03
mov [ebp-10],edx
mov esi,[ebp-18]
mov [ebp-14],esi
lea edx,[esi+edx*2]
push eax
push ecx
mov ecx,edx
call dword ptr ds:[86FB5B8]; System.Number.UInt64ToDecChars(Char*, UInt64)
xor eax,eax
mov [ebp-14],eax
mov eax,1
jmp short M00_L04
M00_L03:
xor eax,eax
mov [ebp-10],eax
M00_L04:
xor edx,edx
mov [ebp-14],edx
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret 8
M00_L05:
xor esi,esi
xor edi,edi
jmp near ptr M00_L00
; Total bytes of code 184
```
```assembly
; System.Number.UInt64ToDecChars(Char*, UInt64)
push ebp
mov ebp,esp
push edi
push esi
push ebx
mov esi,ecx
M01_L00:
cmp dword ptr [ebp+0C],0
jne short M01_L08
mov ecx,[ebp+8]
cmp ecx,0A
jb short M01_L06
cmp ecx,64
jb short M01_L05
M01_L01:
add esi,0FFFFFFFC
mov edx,51EB851F
mov eax,ecx
mul edx
shr edx,5
imul eax,edx,64
sub ecx,eax
mov eax,80D1224
mov eax,[eax+ecx*4+8]
mov [esi],eax
cmp edx,64
jae short M01_L04
M01_L02:
cmp edx,0A
jb short M01_L03
add esi,0FFFFFFFC
mov eax,80D1224
mov edx,[eax+edx*4+8]
mov [esi],edx
jmp short M01_L07
M01_L03:
mov ecx,edx
jmp short M01_L06
M01_L04:
mov ecx,edx
jmp short M01_L01
M01_L05:
mov edx,ecx
jmp short M01_L02
M01_L06:
add esi,0FFFFFFFE
lea eax,[ecx+30]
mov [esi],ax
M01_L07:
mov eax,esi
pop ebx
pop esi
pop edi
pop ebp
ret 8
M01_L08:
mov eax,[ebp+8]
mov edx,[ebp+0C]
mov ecx,3B9ACA00
cmp edx,ecx
jb short M01_L09
mov edi,eax
mov eax,edx
xor edx,edx
div ecx
mov eax,edi
M01_L09:
div ecx
mov edi,edx
push dword ptr [ebp+0C]
push dword ptr [ebp+8]
push 0
push 3B9ACA00
call CORINFO_HELP_ULDIV
mov [ebp+8],eax
mov [ebp+0C],edx
mov ecx,esi
mov esi,9
cmp edi,64
jb short M01_L11
M01_L10:
add ecx,0FFFFFFFC
add esi,0FFFFFFFE
mov edx,51EB851F
mov eax,edi
mul edx
shr edx,5
imul eax,edx,64
sub edi,eax
mov eax,80D1224
mov eax,[eax+edi*4+8]
mov [ecx],eax
cmp edx,64
mov edi,edx
jae short M01_L10
M01_L11:
test edi,edi
je short M01_L13
M01_L12:
dec esi
mov edx,0CCCCCCCD
mov eax,edi
mul edx
shr edx,3
lea eax,[edx+edx*4]
add eax,eax
mov ebx,edi
sub ebx,eax
mov edi,edx
add ecx,0FFFFFFFE
add ebx,30
mov [ecx],bx
test edi,edi
jne short M01_L12
M01_L13:
test esi,esi
jg short M01_L12
mov esi,ecx
jmp near ptr M01_L00
; Total bytes of code 272
```
### Docs
[Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md)
[Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
Run Information
Improvements in System.Tests.Perf_UInt32
Repro
Run Information
Improvements in System.Memory.Span<Char>
Repro