performanceautofiler[bot]
commented
1 year ago Run Information
| Architecture | x86 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | 6123cb00bbec8ae3500c970890f5b0efcf7950e8 |
| Compare | ffbcb8336ac67496b0565112f663f74fda6cac34 |
| Diff | Diff |
Improvements in System.Text.Json.Tests.Perf_Reader
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| [ReadReturnBytes - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Text.Json.Tests.Perf_Reader.ReadReturnBytes(IsDataCompact%3a%20True%2c%20TestCase%3a%20BroadTree).html>) | 10.90 μs | 10.05 μs | 0.92 | 0.07 | False | Trace | Trace |
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.Json.Tests.Perf_Reader*'
### Payloads
[Baseline]()
[Compare]()
### Histogram
#### System.Text.Json.Tests.Perf_Reader.ReadReturnBytes(IsDataCompact: True, TestCase: BroadTree)
```log
```
### Description of detection logic
```IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 10.052542250120714 < 10.36234438348052.
IsChangePoint: Marked as a change because one of 2/8/2023 6:12:15 AM, 2/24/2023 12:59:32 PM, 3/6/2023 11:14:52 AM, 3/14/2023 10:43:28 AM falls between 3/5/2023 5:50:49 PM and 3/14/2023 10:43:28 AM.
IsImprovementStdDev: Marked as improvement because 19.939143898112224 (T) = (0 -10104.180294276146) / Math.Sqrt((367924.62565349165 / (299)) + (1677.284199671737 / (36))) is greater than 1.9671134448822736 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (36) - 2, .975) and 0.06587551906869832 = (10816.738561655615 - 10104.180294276146) / 10816.738561655615 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Text.Json.Tests.Perf_Reader.ReadReturnBytes()
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C4
vzeroupper
vxorps xmm4,xmm4,xmm4
vmovdqu xmmword ptr [ebp-0C4],xmm4
vmovdqu xmmword ptr [ebp-0B4],xmm4
mov eax,0FFFFFF70
M00_L00:
vmovdqu xmmword ptr [ebp+eax-14],xmm4
vmovdqu xmmword ptr [ebp+eax-4],xmm4
vmovdqu xmmword ptr [ebp+eax+0C],xmm4
add eax,30
jne short M00_L00
mov [ebp-14],eax
mov [ebp-10],eax
mov esi,ecx
M00_L01:
mov ecx,[esi+0C]
test ecx,ecx
je near ptr M00_L14
lea edi,[ecx+8]
mov ebx,[ecx+4]
M00_L02:
mov ecx,[esi+8]
test ecx,ecx
je near ptr M00_L04
lea edx,[ecx+8]
mov eax,[ecx+4]
M00_L03:
xor ecx,ecx
mov [ebp-0AC],ecx
mov [ebp-0A8],ecx
vxorps xmm0,xmm0,xmm0
vmovdqu xmmword ptr [ebp-0A4],xmm0
push eax
push edx
push dword ptr [ebp-98]
push dword ptr [ebp-9C]
push dword ptr [ebp-0A0]
push dword ptr [ebp-0A4]
push dword ptr [ebp-0A8]
push dword ptr [ebp-0AC]
push dword ptr [ebp-0B0]
push dword ptr [ebp-0B4]
push dword ptr [ebp-0B8]
push dword ptr [ebp-0BC]
push dword ptr [ebp-0C0]
push dword ptr [ebp-0C4]
lea ecx,[ebp-94]
mov edx,1
call dword ptr ds:[0B0411F8]; System.Text.Json.Utf8JsonReader..ctor(System.ReadOnlySpan`1, Boolean, System.Text.Json.JsonReaderState)
jmp near ptr M00_L06
M00_L04:
xor edx,edx
xor eax,eax
jmp short M00_L03
M00_L05:
movzx ecx,byte ptr [ebp-6C]
mov edx,[ebp-24]
mov eax,[ebp-20]
add ecx,0FFFFFFFB
cmp ecx,6
mov [ebp-0D0],edx
ja near ptr M00_L06
mov [ebp-0CC],esi
lea esi,ds:[0AF0E7A8]
mov esi,[esi+ecx*4]
lea edx,[M00_L01]
add esi,edx
jmp esi
mov esi,[ebp-0CC]
jmp near ptr M00_L06
mov ecx,edi
cmp eax,ebx
ja near ptr M00_L11
mov [ebp-0C8],eax
push eax
mov edx,[ebp-0D0]
call dword ptr ds:[8141E10]; System.Buffer.Memmove(Byte ByRef, Byte ByRef, UIntPtr)
mov esi,[ebp-0C8]
cmp esi,ebx
jae near ptr M00_L15
mov byte ptr [edi+esi],2C
lea ecx,[esi+1]
cmp ecx,ebx
jae near ptr M00_L15
mov byte ptr [edi+ecx],20
add esi,2
cmp esi,ebx
ja near ptr M00_L12
add edi,esi
sub ebx,esi
mov esi,[ebp-0CC]
jmp near ptr M00_L06
mov ecx,edi
cmp eax,ebx
ja near ptr M00_L11
mov [ebp-0C8],eax
push eax
mov edx,[ebp-0D0]
call dword ptr ds:[8141E10]; System.Buffer.Memmove(Byte ByRef, Byte ByRef, UIntPtr)
mov esi,[ebp-0C8]
cmp esi,ebx
jae near ptr M00_L15
mov byte ptr [edi+esi],2C
lea eax,[esi+1]
cmp eax,ebx
jae near ptr M00_L15
mov byte ptr [edi+eax],20
lea eax,[esi+2]
cmp eax,ebx
ja near ptr M00_L12
add edi,eax
sub ebx,eax
mov esi,[ebp-0CC]
jmp near ptr M00_L06
test ebx,ebx
je near ptr M00_L15
mov byte ptr [edi],54
cmp ebx,1
jbe near ptr M00_L15
mov byte ptr [edi+1],72
cmp ebx,2
jbe near ptr M00_L15
mov byte ptr [edi+2],75
cmp ebx,3
jbe near ptr M00_L15
mov byte ptr [edi+3],65
cmp eax,ebx
jae near ptr M00_L15
mov byte ptr [edi+eax],2C
lea edx,[eax+1]
cmp edx,ebx
jae near ptr M00_L15
mov byte ptr [edi+edx],20
add eax,2
cmp eax,ebx
ja near ptr M00_L12
add edi,eax
sub ebx,eax
mov esi,[ebp-0CC]
jmp short M00_L06
test ebx,ebx
je near ptr M00_L15
mov byte ptr [edi],46
cmp ebx,1
jbe near ptr M00_L15
mov byte ptr [edi+1],61
cmp ebx,2
jbe near ptr M00_L15
mov byte ptr [edi+2],6C
cmp ebx,3
jbe near ptr M00_L15
mov byte ptr [edi+3],73
cmp ebx,4
jbe near ptr M00_L15
mov byte ptr [edi+4],65
cmp eax,ebx
jae near ptr M00_L15
mov byte ptr [edi+eax],2C
lea edx,[eax+1]
cmp edx,ebx
jae near ptr M00_L15
mov byte ptr [edi+edx],20
add eax,2
cmp eax,ebx
ja short M00_L12
add edi,eax
sub ebx,eax
mov esi,[ebp-0CC]
M00_L06:
cmp byte ptr [ebp-69],0
jne short M00_L07
lea ecx,[ebp-94]
call dword ptr ds:[0B041408]; System.Text.Json.Utf8JsonReader.ReadSingleSegment()
jmp short M00_L08
M00_L07:
lea ecx,[ebp-94]
call dword ptr ds:[0B0417B0]
M00_L08:
movzx eax,al
test eax,eax
jne short M00_L09
cmp byte ptr [ebp-70],0
je short M00_L10
cmp byte ptr [ebp-6C],0
je short M00_L13
M00_L09:
test eax,eax
jne near ptr M00_L05
M00_L10:
mov eax,[esi+0C]
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
M00_L11:
call dword ptr ds:[8217288]
int 3
M00_L12:
call dword ptr ds:[8217270]
int 3
M00_L13:
xor ecx,ecx
push 0
push 0
push ecx
lea ecx,[ebp-94]
mov edx,20
call dword ptr ds:[0B043C00]
int 3
M00_L14:
xor edi,edi
xor ebx,ebx
jmp near ptr M00_L02
M00_L15:
call CORINFO_HELP_RNGCHKFAIL
int 3
; Total bytes of code 804
```
```assembly
; System.Text.Json.Utf8JsonReader..ctor(System.ReadOnlySpan`1, Boolean, System.Text.Json.JsonReaderState)
push ebp
mov ebp,esp
push edi
push esi
sub esp,10
vzeroupper
xor eax,eax
mov [ebp-18],eax
mov [ebp-14],eax
mov eax,ecx
lea edi,[eax+30]
lea esi,[ebp+38]
call CORINFO_HELP_ASSIGN_BYREF
movsd
mov [eax+24],dl
mov byte ptr [eax+25],0
mov ecx,eax
mov edx,[ebp+8]
mov [ecx],edx
mov edx,[ebp+0C]
mov [ecx+4],edx
lea ecx,[eax+8]
mov edx,[ebp+10]
mov [ecx],edx
mov edx,[ebp+14]
mov [ecx+4],edx
movzx ecx,byte ptr [ebp+18]
mov [eax+26],cl
movzx ecx,byte ptr [ebp+19]
mov [eax+27],cl
movzx ecx,byte ptr [ebp+1A]
mov [eax+2E],cl
movzx ecx,byte ptr [ebp+1B]
mov [eax+2C],cl
movzx ecx,byte ptr [ebp+1C]
mov [eax+28],cl
movzx ecx,byte ptr [ebp+1D]
mov [eax+29],cl
mov ecx,[ebp+20]
mov [eax+38],ecx
mov ecx,[ebp+24]
mov [eax+3C],ecx
cmp dword ptr [eax+38],0
jne short M01_L00
mov dword ptr [eax+38],40
M01_L00:
lea edi,[eax+40]
lea esi,[ebp+28]
movsd
movsd
call CORINFO_HELP_ASSIGN_BYREF
movsd
xor ecx,ecx
mov [eax+20],ecx
lea ecx,[eax+18]
xor edx,edx
mov [ecx],edx
mov [ecx+4],edx
lea ecx,[eax+10]
mov [ecx],edx
mov [ecx+4],edx
movzx ecx,byte ptr [eax+24]
mov [eax+2A],cl
mov byte ptr [eax+2B],0
mov [eax+70],edx
mov [eax+74],edx
mov [eax+58],edx
mov [eax+5C],edx
mov [eax+50],edx
mov [eax+54],edx
vxorps xmm0,xmm0,xmm0
vmovq qword ptr [eax+60],xmm0
vmovq qword ptr [eax+68],xmm0
mov byte ptr [eax+2D],0
mov esi,ds:[6894E98]
add esi,4
lea edi,[ebp-18]
mov ecx,4
rep movsd
lea edi,[eax+78]
lea esi,[ebp-18]
call CORINFO_HELP_ASSIGN_BYREF
call CORINFO_HELP_ASSIGN_BYREF
movsd
movsd
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 38
; Total bytes of code 264
```
```assembly
; System.Buffer.Memmove(Byte ByRef, Byte ByRef, UIntPtr)
push ebp
mov ebp,esp
push edi
push esi
push ebx
vzeroupper
mov eax,[ebp+8]
mov esi,ecx
sub esi,edx
cmp esi,eax
jb near ptr M02_L10
mov esi,edx
sub esi,ecx
cmp esi,eax
jb near ptr M02_L10
lea esi,[edx+eax]
lea edi,[ecx+eax]
cmp eax,10
jbe short M02_L05
cmp eax,40
ja short M02_L03
M02_L00:
vmovups xmm0,[edx]
vmovups [ecx],xmm0
cmp eax,20
jbe short M02_L01
vmovups xmm0,[edx+10]
vmovups [ecx+10],xmm0
cmp eax,30
ja near ptr M02_L09
M02_L01:
vmovups xmm0,[esi-10]
vmovups [edi-10],xmm0
M02_L02:
pop ebx
pop esi
pop edi
pop ebp
ret 4
M02_L03:
cmp eax,800
ja near ptr M02_L11
mov ebx,eax
shr ebx,6
M02_L04:
vmovdqu ymm0,ymmword ptr [edx]
vmovdqu ymmword ptr [ecx],ymm0
vmovdqu ymm0,ymmword ptr [edx+20]
vmovdqu ymmword ptr [ecx+20],ymm0
add ecx,40
add edx,40
dec ebx
jne short M02_L04
and eax,3F
cmp eax,10
ja short M02_L00
jmp short M02_L01
M02_L05:
test al,18
jne short M02_L06
test al,4
jne short M02_L08
test eax,eax
je short M02_L02
movzx edx,byte ptr [edx]
mov [ecx],dl
test al,2
je short M02_L02
movsx eax,word ptr [esi-2]
mov [edi-2],ax
jmp short M02_L02
M02_L06:
mov eax,[edx]
mov [ecx],eax
mov edx,[edx+4]
mov [ecx+4],edx
mov ecx,[esi-8]
mov [edi-8],ecx
M02_L07:
mov eax,[esi-4]
mov [edi-4],eax
jmp short M02_L02
M02_L08:
mov eax,[edx]
mov [ecx],eax
jmp short M02_L07
M02_L09:
vmovups xmm0,[edx+20]
vmovups [ecx+20],xmm0
jmp near ptr M02_L01
M02_L10:
cmp ecx,edx
je near ptr M02_L02
M02_L11:
push eax
call dword ptr ds:[8141E28]
jmp near ptr M02_L02
; Total bytes of code 250
```
```assembly
; System.Text.Json.Utf8JsonReader.ReadSingleSegment()
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C
mov esi,ecx
xor ebx,ebx
xor ecx,ecx
mov [esi+70],ecx
mov [esi+74],ecx
mov byte ptr [esi+2E],0
mov ecx,[esi+20]
mov eax,ecx
sar eax,1F
cmp ecx,[esi+34]
sbb eax,0
jl short M03_L02
cmp byte ptr [esi+27],0
je near ptr M03_L15
cmp byte ptr [esi+24],0
je near ptr M03_L15
cmp byte ptr [esi+2B],0
je short M03_L00
movzx ecx,byte ptr [esi+2A]
test ecx,ecx
je near ptr M03_L15
M03_L00:
cmp dword ptr [esi+4C],0
jne near ptr M03_L17
cmp byte ptr [esi+3C],2
jne short M03_L01
movzx ecx,byte ptr [esi+28]
cmp ecx,6
je near ptr M03_L15
M03_L01:
movzx ecx,byte ptr [esi+28]
cmp ecx,4
je near ptr M03_L15
cmp ecx,2
jne near ptr M03_L18
jmp near ptr M03_L15
M03_L02:
mov ecx,[esi+20]
lea eax,[esi+30]
cmp ecx,[eax+4]
jae near ptr M03_L22
mov eax,[eax]
movzx edx,byte ptr [eax+ecx]
cmp edx,20
jg near ptr M03_L06
mov ecx,esi
call dword ptr ds:[0B041468]
mov ecx,[esi+20]
mov edx,ecx
mov eax,edx
sar eax,1F
cmp edx,[esi+34]
sbb eax,0
jl short M03_L05
cmp byte ptr [esi+27],0
je near ptr M03_L15
cmp byte ptr [esi+24],0
je near ptr M03_L15
cmp byte ptr [esi+2B],0
je short M03_L03
movzx ecx,byte ptr [esi+2A]
test ecx,ecx
je near ptr M03_L15
M03_L03:
cmp dword ptr [esi+4C],0
jne near ptr M03_L19
cmp byte ptr [esi+3C],2
jne short M03_L04
movzx ecx,byte ptr [esi+28]
cmp ecx,6
je near ptr M03_L15
M03_L04:
movzx ecx,byte ptr [esi+28]
cmp ecx,4
je near ptr M03_L15
cmp ecx,2
jne near ptr M03_L20
jmp near ptr M03_L15
M03_L05:
lea edx,[esi+30]
cmp ecx,[edx+4]
jae near ptr M03_L22
mov edx,[edx]
movzx edx,byte ptr [edx+ecx]
M03_L06:
mov ecx,[esi+20]
mov eax,ecx
sar eax,1F
lea ebx,[esi+18]
mov [ebx],ecx
mov [ebx+4],eax
movzx ebx,byte ptr [esi+28]
test ebx,ebx
je near ptr M03_L16
cmp edx,2F
jne short M03_L08
M03_L07:
mov ecx,esi
call dword ptr ds:[0B0415E8]; System.Text.Json.Utf8JsonReader.ConsumeNextTokenOrRollback(Byte)
mov ebx,eax
jmp near ptr M03_L15
M03_L08:
cmp ebx,1
jne short M03_L11
cmp edx,7D
jne short M03_L09
mov ecx,esi
call dword ptr ds:[0B0413A8]; System.Text.Json.Utf8JsonReader.EndObject()
jmp near ptr M03_L14
M03_L09:
cmp edx,22
jne near ptr M03_L21
mov ebx,[esi+20]
lea ecx,[esi+8]
mov edi,[ecx]
mov eax,[ecx+4]
mov [ebp-10],eax
mov ecx,esi
mov edx,[ecx]
mov ecx,[ecx+4]
mov [ebp-14],edx
mov [ebp-18],ecx
mov ecx,esi
call dword ptr ds:[0B0414F8]; System.Text.Json.Utf8JsonReader.ConsumePropertyName()
test eax,eax
jne short M03_L10
mov [esi+20],ebx
mov byte ptr [esi+28],1
lea ecx,[esi+8]
mov [ecx],edi
mov edi,[ebp-10]
mov [ecx+4],edi
mov edi,[ebp-14]
mov [esi],edi
mov edi,[ebp-18]
mov [esi+4],edi
mov ebx,eax
jmp short M03_L15
M03_L10:
mov ebx,eax
jmp short M03_L15
M03_L11:
cmp ebx,3
jne short M03_L13
cmp edx,5D
jne short M03_L12
mov ecx,esi
call dword ptr ds:[0B0413D8]; System.Text.Json.Utf8JsonReader.EndArray()
jmp short M03_L14
M03_L12:
mov ecx,esi
call dword ptr ds:[0B041480]; System.Text.Json.Utf8JsonReader.ConsumeValue(Byte)
mov ebx,eax
jmp short M03_L15
M03_L13:
cmp ebx,5
jne near ptr M03_L07
jmp short M03_L12
M03_L14:
mov ebx,1
M03_L15:
mov eax,ebx
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
M03_L16:
mov ecx,esi
call dword ptr ds:[0B041450]; System.Text.Json.Utf8JsonReader.ReadFirstToken(Byte)
mov ebx,eax
jmp short M03_L15
M03_L17:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,19
call dword ptr ds:[0B043C00]
int 3
M03_L18:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,16
call dword ptr ds:[0B043C00]
int 3
M03_L19:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,19
call dword ptr ds:[0B043C00]
int 3
M03_L20:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,16
call dword ptr ds:[0B043C00]
int 3
M03_L21:
xor ecx,ecx
push edx
push 0
push ecx
mov ecx,esi
mov edx,0C
call dword ptr ds:[0B043C00]
int 3
M03_L22:
call CORINFO_HELP_RNGCHKFAIL
int 3
; Total bytes of code 639
```
### Compare Jit Disasm
```assembly
; System.Text.Json.Tests.Perf_Reader.ReadReturnBytes()
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C4
vzeroupper
vxorps xmm4,xmm4,xmm4
vmovdqu xmmword ptr [ebp-0C4],xmm4
vmovdqu xmmword ptr [ebp-0B4],xmm4
mov eax,0FFFFFF70
M00_L00:
vmovdqu xmmword ptr [ebp+eax-14],xmm4
vmovdqu xmmword ptr [ebp+eax-4],xmm4
vmovdqu xmmword ptr [ebp+eax+0C],xmm4
add eax,30
jne short M00_L00
mov [ebp-14],eax
mov [ebp-10],eax
mov esi,ecx
M00_L01:
mov ecx,[esi+0C]
test ecx,ecx
je near ptr M00_L14
lea edi,[ecx+8]
mov ebx,[ecx+4]
M00_L02:
mov ecx,[esi+8]
test ecx,ecx
je near ptr M00_L04
lea edx,[ecx+8]
mov eax,[ecx+4]
M00_L03:
xor ecx,ecx
mov [ebp-0AC],ecx
mov [ebp-0A8],ecx
vxorps xmm0,xmm0,xmm0
vmovdqu xmmword ptr [ebp-0A4],xmm0
push eax
push edx
push dword ptr [ebp-98]
push dword ptr [ebp-9C]
push dword ptr [ebp-0A0]
push dword ptr [ebp-0A4]
push dword ptr [ebp-0A8]
push dword ptr [ebp-0AC]
push dword ptr [ebp-0B0]
push dword ptr [ebp-0B4]
push dword ptr [ebp-0B8]
push dword ptr [ebp-0BC]
push dword ptr [ebp-0C0]
push dword ptr [ebp-0C4]
lea ecx,[ebp-94]
mov edx,1
call dword ptr ds:[0BCB11F8]; System.Text.Json.Utf8JsonReader..ctor(System.ReadOnlySpan`1, Boolean, System.Text.Json.JsonReaderState)
jmp near ptr M00_L06
M00_L04:
xor edx,edx
xor eax,eax
jmp short M00_L03
M00_L05:
movzx ecx,byte ptr [ebp-6C]
mov edx,[ebp-24]
mov eax,[ebp-20]
add ecx,0FFFFFFFB
cmp ecx,6
mov [ebp-0D0],edx
ja near ptr M00_L06
mov [ebp-0CC],esi
lea esi,ds:[0BB7E528]
mov esi,[esi+ecx*4]
lea edx,[M00_L01]
add esi,edx
jmp esi
mov esi,[ebp-0CC]
jmp near ptr M00_L06
mov ecx,edi
cmp eax,ebx
ja near ptr M00_L11
mov [ebp-0C8],eax
push eax
mov edx,[ebp-0D0]
call dword ptr ds:[8D41D68]; System.Buffer.Memmove(Byte ByRef, Byte ByRef, UIntPtr)
mov esi,[ebp-0C8]
cmp esi,ebx
jae near ptr M00_L15
mov byte ptr [edi+esi],2C
lea ecx,[esi+1]
cmp ecx,ebx
jae near ptr M00_L15
mov byte ptr [edi+ecx],20
add esi,2
cmp esi,ebx
ja near ptr M00_L12
add edi,esi
sub ebx,esi
mov esi,[ebp-0CC]
jmp near ptr M00_L06
mov ecx,edi
cmp eax,ebx
ja near ptr M00_L11
mov [ebp-0C8],eax
push eax
mov edx,[ebp-0D0]
call dword ptr ds:[8D41D68]; System.Buffer.Memmove(Byte ByRef, Byte ByRef, UIntPtr)
mov esi,[ebp-0C8]
cmp esi,ebx
jae near ptr M00_L15
mov byte ptr [edi+esi],2C
lea eax,[esi+1]
cmp eax,ebx
jae near ptr M00_L15
mov byte ptr [edi+eax],20
lea eax,[esi+2]
cmp eax,ebx
ja near ptr M00_L12
add edi,eax
sub ebx,eax
mov esi,[ebp-0CC]
jmp near ptr M00_L06
test ebx,ebx
je near ptr M00_L15
mov byte ptr [edi],54
cmp ebx,1
jbe near ptr M00_L15
mov byte ptr [edi+1],72
cmp ebx,2
jbe near ptr M00_L15
mov byte ptr [edi+2],75
cmp ebx,3
jbe near ptr M00_L15
mov byte ptr [edi+3],65
cmp eax,ebx
jae near ptr M00_L15
mov byte ptr [edi+eax],2C
lea edx,[eax+1]
cmp edx,ebx
jae near ptr M00_L15
mov byte ptr [edi+edx],20
add eax,2
cmp eax,ebx
ja near ptr M00_L12
add edi,eax
sub ebx,eax
mov esi,[ebp-0CC]
jmp short M00_L06
test ebx,ebx
je near ptr M00_L15
mov byte ptr [edi],46
cmp ebx,1
jbe near ptr M00_L15
mov byte ptr [edi+1],61
cmp ebx,2
jbe near ptr M00_L15
mov byte ptr [edi+2],6C
cmp ebx,3
jbe near ptr M00_L15
mov byte ptr [edi+3],73
cmp ebx,4
jbe near ptr M00_L15
mov byte ptr [edi+4],65
cmp eax,ebx
jae near ptr M00_L15
mov byte ptr [edi+eax],2C
lea edx,[eax+1]
cmp edx,ebx
jae near ptr M00_L15
mov byte ptr [edi+edx],20
add eax,2
cmp eax,ebx
ja short M00_L12
add edi,eax
sub ebx,eax
mov esi,[ebp-0CC]
M00_L06:
cmp byte ptr [ebp-69],0
jne short M00_L07
lea ecx,[ebp-94]
call dword ptr ds:[0BCB1408]; System.Text.Json.Utf8JsonReader.ReadSingleSegment()
jmp short M00_L08
M00_L07:
lea ecx,[ebp-94]
call dword ptr ds:[0BCB17B0]
M00_L08:
movzx eax,al
test eax,eax
jne short M00_L09
cmp byte ptr [ebp-70],0
je short M00_L10
cmp byte ptr [ebp-6C],0
je short M00_L13
M00_L09:
test eax,eax
jne near ptr M00_L05
M00_L10:
mov eax,[esi+0C]
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
M00_L11:
call dword ptr ds:[8E17288]
int 3
M00_L12:
call dword ptr ds:[8E17270]
int 3
M00_L13:
xor ecx,ecx
push 0
push 0
push ecx
lea ecx,[ebp-94]
mov edx,20
call dword ptr ds:[0BCB3C00]
int 3
M00_L14:
xor edi,edi
xor ebx,ebx
jmp near ptr M00_L02
M00_L15:
call CORINFO_HELP_RNGCHKFAIL
int 3
; Total bytes of code 804
```
```assembly
; System.Text.Json.Utf8JsonReader..ctor(System.ReadOnlySpan`1, Boolean, System.Text.Json.JsonReaderState)
push ebp
mov ebp,esp
push edi
push esi
sub esp,10
vzeroupper
xor eax,eax
mov [ebp-18],eax
mov [ebp-14],eax
mov eax,ecx
lea edi,[eax+30]
lea esi,[ebp+38]
call CORINFO_HELP_ASSIGN_BYREF
movsd
mov [eax+24],dl
mov byte ptr [eax+25],0
mov ecx,eax
mov edx,[ebp+8]
mov [ecx],edx
mov edx,[ebp+0C]
mov [ecx+4],edx
lea ecx,[eax+8]
mov edx,[ebp+10]
mov [ecx],edx
mov edx,[ebp+14]
mov [ecx+4],edx
movzx ecx,byte ptr [ebp+18]
mov [eax+26],cl
movzx ecx,byte ptr [ebp+19]
mov [eax+27],cl
movzx ecx,byte ptr [ebp+1A]
mov [eax+2E],cl
movzx ecx,byte ptr [ebp+1B]
mov [eax+2C],cl
movzx ecx,byte ptr [ebp+1C]
mov [eax+28],cl
movzx ecx,byte ptr [ebp+1D]
mov [eax+29],cl
mov ecx,[ebp+20]
mov [eax+38],ecx
mov ecx,[ebp+24]
mov [eax+3C],ecx
cmp dword ptr [eax+38],0
jne short M01_L00
mov dword ptr [eax+38],40
M01_L00:
lea edi,[eax+40]
lea esi,[ebp+28]
movsd
movsd
call CORINFO_HELP_ASSIGN_BYREF
movsd
xor ecx,ecx
mov [eax+20],ecx
lea ecx,[eax+18]
xor edx,edx
mov [ecx],edx
mov [ecx+4],edx
lea ecx,[eax+10]
mov [ecx],edx
mov [ecx+4],edx
movzx ecx,byte ptr [eax+24]
mov [eax+2A],cl
mov byte ptr [eax+2B],0
mov [eax+70],edx
mov [eax+74],edx
mov [eax+58],edx
mov [eax+5C],edx
mov [eax+50],edx
mov [eax+54],edx
vxorps xmm0,xmm0,xmm0
vmovq qword ptr [eax+60],xmm0
vmovq qword ptr [eax+68],xmm0
mov byte ptr [eax+2D],0
mov esi,ds:[7464E90]
add esi,4
lea edi,[ebp-18]
mov ecx,4
rep movsd
lea edi,[eax+78]
lea esi,[ebp-18]
call CORINFO_HELP_ASSIGN_BYREF
call CORINFO_HELP_ASSIGN_BYREF
movsd
movsd
lea esp,[ebp-8]
pop esi
pop edi
pop ebp
ret 38
; Total bytes of code 264
```
```assembly
; System.Buffer.Memmove(Byte ByRef, Byte ByRef, UIntPtr)
push ebp
mov ebp,esp
push edi
push esi
push ebx
vzeroupper
mov eax,[ebp+8]
mov esi,ecx
sub esi,edx
cmp esi,eax
jb near ptr M02_L10
mov esi,edx
sub esi,ecx
cmp esi,eax
jb near ptr M02_L10
lea esi,[edx+eax]
lea edi,[ecx+eax]
cmp eax,10
jbe short M02_L05
cmp eax,40
ja short M02_L03
M02_L00:
vmovups xmm0,[edx]
vmovups [ecx],xmm0
cmp eax,20
jbe short M02_L01
vmovups xmm0,[edx+10]
vmovups [ecx+10],xmm0
cmp eax,30
ja near ptr M02_L09
M02_L01:
vmovups xmm0,[esi-10]
vmovups [edi-10],xmm0
M02_L02:
pop ebx
pop esi
pop edi
pop ebp
ret 4
M02_L03:
cmp eax,800
ja near ptr M02_L11
mov ebx,eax
shr ebx,6
M02_L04:
vmovdqu ymm0,ymmword ptr [edx]
vmovdqu ymmword ptr [ecx],ymm0
vmovdqu ymm0,ymmword ptr [edx+20]
vmovdqu ymmword ptr [ecx+20],ymm0
add ecx,40
add edx,40
dec ebx
jne short M02_L04
and eax,3F
cmp eax,10
ja short M02_L00
jmp short M02_L01
M02_L05:
test al,18
jne short M02_L06
test al,4
jne short M02_L08
test eax,eax
je short M02_L02
movzx edx,byte ptr [edx]
mov [ecx],dl
test al,2
je short M02_L02
movsx eax,word ptr [esi-2]
mov [edi-2],ax
jmp short M02_L02
M02_L06:
mov eax,[edx]
mov [ecx],eax
mov edx,[edx+4]
mov [ecx+4],edx
mov ecx,[esi-8]
mov [edi-8],ecx
M02_L07:
mov eax,[esi-4]
mov [edi-4],eax
jmp short M02_L02
M02_L08:
mov eax,[edx]
mov [ecx],eax
jmp short M02_L07
M02_L09:
vmovups xmm0,[edx+20]
vmovups [ecx+20],xmm0
jmp near ptr M02_L01
M02_L10:
cmp ecx,edx
je near ptr M02_L02
M02_L11:
push eax
call dword ptr ds:[8D41D80]
jmp near ptr M02_L02
; Total bytes of code 250
```
```assembly
; System.Text.Json.Utf8JsonReader.ReadSingleSegment()
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C
mov esi,ecx
xor ebx,ebx
xor ecx,ecx
mov [esi+70],ecx
mov [esi+74],ecx
mov byte ptr [esi+2E],0
mov ecx,[esi+20]
mov eax,ecx
sar eax,1F
cmp ecx,[esi+34]
sbb eax,0
jl short M03_L02
cmp byte ptr [esi+27],0
je near ptr M03_L15
cmp byte ptr [esi+24],0
je near ptr M03_L15
cmp byte ptr [esi+2B],0
je short M03_L00
movzx ecx,byte ptr [esi+2A]
test ecx,ecx
je near ptr M03_L15
M03_L00:
cmp dword ptr [esi+4C],0
jne near ptr M03_L17
cmp byte ptr [esi+3C],2
jne short M03_L01
movzx ecx,byte ptr [esi+28]
cmp ecx,6
je near ptr M03_L15
M03_L01:
movzx ecx,byte ptr [esi+28]
cmp ecx,4
je near ptr M03_L15
cmp ecx,2
jne near ptr M03_L18
jmp near ptr M03_L15
M03_L02:
mov ecx,[esi+20]
lea eax,[esi+30]
cmp ecx,[eax+4]
jae near ptr M03_L22
mov eax,[eax]
movzx edx,byte ptr [eax+ecx]
cmp edx,20
jg near ptr M03_L06
mov ecx,esi
call dword ptr ds:[0BCB1468]
mov ecx,[esi+20]
mov edx,ecx
mov eax,edx
sar eax,1F
cmp edx,[esi+34]
sbb eax,0
jl short M03_L05
cmp byte ptr [esi+27],0
je near ptr M03_L15
cmp byte ptr [esi+24],0
je near ptr M03_L15
cmp byte ptr [esi+2B],0
je short M03_L03
movzx ecx,byte ptr [esi+2A]
test ecx,ecx
je near ptr M03_L15
M03_L03:
cmp dword ptr [esi+4C],0
jne near ptr M03_L19
cmp byte ptr [esi+3C],2
jne short M03_L04
movzx ecx,byte ptr [esi+28]
cmp ecx,6
je near ptr M03_L15
M03_L04:
movzx ecx,byte ptr [esi+28]
cmp ecx,4
je near ptr M03_L15
cmp ecx,2
jne near ptr M03_L20
jmp near ptr M03_L15
M03_L05:
lea edx,[esi+30]
cmp ecx,[edx+4]
jae near ptr M03_L22
mov edx,[edx]
movzx edx,byte ptr [edx+ecx]
M03_L06:
mov ecx,[esi+20]
mov eax,ecx
sar eax,1F
lea ebx,[esi+18]
mov [ebx],ecx
mov [ebx+4],eax
movzx ebx,byte ptr [esi+28]
test ebx,ebx
je near ptr M03_L16
cmp edx,2F
jne short M03_L08
M03_L07:
mov ecx,esi
call dword ptr ds:[0BCB15E8]; System.Text.Json.Utf8JsonReader.ConsumeNextTokenOrRollback(Byte)
mov ebx,eax
jmp near ptr M03_L15
M03_L08:
cmp ebx,1
jne short M03_L11
cmp edx,7D
jne short M03_L09
mov ecx,esi
call dword ptr ds:[0BCB13A8]; System.Text.Json.Utf8JsonReader.EndObject()
jmp near ptr M03_L14
M03_L09:
cmp edx,22
jne near ptr M03_L21
mov ebx,[esi+20]
lea ecx,[esi+8]
mov edi,[ecx]
mov eax,[ecx+4]
mov [ebp-10],eax
mov ecx,esi
mov edx,[ecx]
mov ecx,[ecx+4]
mov [ebp-14],edx
mov [ebp-18],ecx
mov ecx,esi
call dword ptr ds:[0BCB14F8]; System.Text.Json.Utf8JsonReader.ConsumePropertyName()
test eax,eax
jne short M03_L10
mov [esi+20],ebx
mov byte ptr [esi+28],1
lea ecx,[esi+8]
mov [ecx],edi
mov edi,[ebp-10]
mov [ecx+4],edi
mov edi,[ebp-14]
mov [esi],edi
mov edi,[ebp-18]
mov [esi+4],edi
mov ebx,eax
jmp short M03_L15
M03_L10:
mov ebx,eax
jmp short M03_L15
M03_L11:
cmp ebx,3
jne short M03_L13
cmp edx,5D
jne short M03_L12
mov ecx,esi
call dword ptr ds:[0BCB13D8]; System.Text.Json.Utf8JsonReader.EndArray()
jmp short M03_L14
M03_L12:
mov ecx,esi
call dword ptr ds:[0BCB1480]; System.Text.Json.Utf8JsonReader.ConsumeValue(Byte)
mov ebx,eax
jmp short M03_L15
M03_L13:
cmp ebx,5
jne near ptr M03_L07
jmp short M03_L12
M03_L14:
mov ebx,1
M03_L15:
mov eax,ebx
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
M03_L16:
mov ecx,esi
call dword ptr ds:[0BCB1450]; System.Text.Json.Utf8JsonReader.ReadFirstToken(Byte)
mov ebx,eax
jmp short M03_L15
M03_L17:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,19
call dword ptr ds:[0BCB3C00]
int 3
M03_L18:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,16
call dword ptr ds:[0BCB3C00]
int 3
M03_L19:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,19
call dword ptr ds:[0BCB3C00]
int 3
M03_L20:
xor edi,edi
push 0
push 0
push edi
mov ecx,esi
mov edx,16
call dword ptr ds:[0BCB3C00]
int 3
M03_L21:
xor ecx,ecx
push edx
push 0
push ecx
mov ecx,esi
mov edx,0C
call dword ptr ds:[0BCB3C00]
int 3
M03_L22:
call CORINFO_HELP_RNGCHKFAIL
int 3
; Total bytes of code 639
```
### Docs
[Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md)
[Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
Run Information
| Architecture | x86 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | 6123cb00bbec8ae3500c970890f5b0efcf7950e8 |
| Compare | ffbcb8336ac67496b0565112f663f74fda6cac34 |
| Diff | Diff |
Improvements in System.Tests.Perf_Char
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| [Char_ToLowerInvariant - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Tests.Perf_Char.Char_ToLowerInvariant(input%3a%20%22Hello%20World!%22).html>) | 15.42 ns | 13.45 ns | 0.87 | 0.03 | False | 176.53220895502412 | 181.5922145090201 | 1.02866335601842) | Trace | Trace |
| [Char_ToUpperInvariant - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Tests.Perf_Char.Char_ToUpperInvariant(input%3a%20%22Hello%20World!%22).html>) | 20.07 ns | 14.77 ns | 0.74 | 0.03 | False | 177.15208878435 | 184.4818076073381 | 1.0413752887323315) | Trace | Trace |
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Char*'
### Payloads
[Baseline]()
[Compare]()
### Histogram
#### System.Tests.Perf_Char.Char_ToLowerInvariant(input: "Hello World!")
```log
```
### Description of detection logic
```IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 13.447682824647696 < 14.662409771856094.
IsChangePoint: Marked as a change because one of 1/3/2023 6:29:42 AM, 1/5/2023 11:35:29 PM, 1/15/2023 2:31:53 AM, 1/18/2023 8:37:25 PM, 1/30/2023 9:42:46 PM, 2/9/2023 4:27:10 AM, 2/16/2023 9:36:08 AM, 2/20/2023 10:31:48 AM, 3/6/2023 11:14:52 AM, 3/14/2023 10:43:28 AM falls between 3/5/2023 5:50:49 PM and 3/14/2023 10:43:28 AM.
IsImprovementStdDev: Marked as improvement because 22.70344721650576 (T) = (0 -13.13658115299593) / Math.Sqrt((0.973386160341024 / (299)) + (0.019069224907799505 / (36))) is greater than 1.9671134448822736 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (36) - 2, .975) and 0.09610986212101447 = (14.53338254560609 - 13.13658115299593) / 14.53338254560609 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Tests.Perf_Char.Char_ToLowerInvariant(System.String)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C
xor eax,eax
mov [ebp-10],eax
mov esi,edx
xor edi,edi
xor ebx,ebx
mov eax,[esi+4]
mov [ebp-18],eax
test eax,eax
jle short M00_L05
M00_L00:
movzx edx,word ptr [esi+ebx*2+8]
cmp edx,7F
ja short M00_L03
lea ecx,[edx-41]
cmp ecx,19
jbe short M00_L02
M00_L01:
mov ecx,edx
jmp short M00_L04
M00_L02:
or edx,20
movzx edx,dl
jmp short M00_L01
M00_L03:
mov ecx,ds:[6B912F0]
mov [ebp-14],dx
cmp [ecx],cl
xor edx,edx
mov [ebp-10],edx
push 1
lea edx,[ebp-10]
push edx
push 1
push 0
lea edx,[ebp-14]
call dword ptr ds:[866B420]
movzx ecx,word ptr [ebp-10]
M00_L04:
add edi,ecx
inc ebx
mov eax,[ebp-18]
cmp eax,ebx
jg short M00_L00
M00_L05:
mov eax,edi
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
; Total bytes of code 120
```
### Compare Jit Disasm
```assembly
; System.Tests.Perf_Char.Char_ToLowerInvariant(System.String)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C
xor eax,eax
mov [ebp-10],eax
mov esi,edx
xor edi,edi
xor ebx,ebx
mov eax,[esi+4]
mov [ebp-18],eax
test eax,eax
jle short M00_L05
M00_L00:
movzx edx,word ptr [esi+ebx*2+8]
cmp edx,7F
ja short M00_L03
lea ecx,[edx-41]
cmp ecx,19
jbe short M00_L02
M00_L01:
mov ecx,edx
jmp short M00_L04
M00_L02:
or edx,20
movzx edx,dl
jmp short M00_L01
M00_L03:
mov ecx,ds:[71012E8]
mov [ebp-14],dx
cmp [ecx],cl
xor edx,edx
mov [ebp-10],edx
push 1
lea edx,[ebp-10]
push edx
push 1
push 0
lea edx,[ebp-14]
call dword ptr ds:[8ABB420]
movzx ecx,word ptr [ebp-10]
M00_L04:
add edi,ecx
inc ebx
mov eax,[ebp-18]
cmp eax,ebx
jg short M00_L00
M00_L05:
mov eax,edi
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
; Total bytes of code 120
```
#### System.Tests.Perf_Char.Char_ToUpperInvariant(input: "Hello World!")
```log
```
### Description of detection logic
```IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 14.766993240667302 < 19.073223165274964.
IsChangePoint: Marked as a change because one of 1/3/2023 6:29:42 AM, 1/5/2023 11:35:29 PM, 1/15/2023 2:31:53 AM, 1/18/2023 8:37:25 PM, 1/30/2023 9:42:46 PM, 2/9/2023 4:27:10 AM, 2/16/2023 9:36:08 AM, 2/20/2023 10:31:48 AM, 3/6/2023 11:14:52 AM, 3/14/2023 10:43:28 AM falls between 3/5/2023 5:50:49 PM and 3/14/2023 10:43:28 AM.
IsImprovementStdDev: Marked as improvement because 23.277740808846954 (T) = (0 -15.016095456340771) / Math.Sqrt((6.561904886229808 / (299)) + (0.01816447348796333 / (36))) is greater than 1.9671134448822736 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (36) - 2, .975) and 0.18849165139198448 = (18.503932192562107 - 15.016095456340771) / 18.503932192562107 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```### Baseline Jit Disasm
```assembly
; System.Tests.Perf_Char.Char_ToUpperInvariant(System.String)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C
xor eax,eax
mov [ebp-10],eax
mov esi,edx
xor edi,edi
xor ebx,ebx
mov eax,[esi+4]
mov [ebp-18],eax
test eax,eax
jle short M00_L04
M00_L00:
movzx edx,word ptr [esi+ebx*2+8]
cmp edx,7F
ja short M00_L02
lea ecx,[edx-61]
cmp ecx,19
ja short M00_L01
and edx,5F
M00_L01:
mov ecx,edx
jmp short M00_L03
M00_L02:
mov ecx,ds:[77912F0]
mov [ebp-14],dx
cmp [ecx],cl
xor edx,edx
mov [ebp-10],edx
push 1
lea edx,[ebp-10]
push edx
push 1
push 1
lea edx,[ebp-14]
call dword ptr ds:[91BB420]
movzx ecx,word ptr [ebp-10]
M00_L03:
add edi,ecx
inc ebx
mov eax,[ebp-18]
cmp eax,ebx
jg short M00_L00
M00_L04:
mov eax,edi
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
; Total bytes of code 115
```
### Compare Jit Disasm
```assembly
; System.Tests.Perf_Char.Char_ToUpperInvariant(System.String)
push ebp
mov ebp,esp
push edi
push esi
push ebx
sub esp,0C
xor eax,eax
mov [ebp-10],eax
mov esi,edx
xor edi,edi
xor ebx,ebx
mov eax,[esi+4]
mov [ebp-18],eax
test eax,eax
jle short M00_L04
M00_L00:
movzx edx,word ptr [esi+ebx*2+8]
cmp edx,7F
ja short M00_L02
lea ecx,[edx-61]
cmp ecx,19
ja short M00_L01
and edx,5F
M00_L01:
mov ecx,edx
jmp short M00_L03
M00_L02:
mov ecx,ds:[6B812E8]
mov [ebp-14],dx
cmp [ecx],cl
xor edx,edx
mov [ebp-10],edx
push 1
lea edx,[ebp-10]
push edx
push 1
push 1
lea edx,[ebp-14]
call dword ptr ds:[86DB420]
movzx ecx,word ptr [ebp-10]
M00_L03:
add edi,ecx
inc ebx
mov eax,[ebp-18]
cmp eax,ebx
jg short M00_L00
M00_L04:
mov eax,edi
lea esp,[ebp-0C]
pop ebx
pop esi
pop edi
pop ebp
ret
; Total bytes of code 115
```
### Docs
[Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md)
[Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
Run Information
| Architecture | x86 |
|---|---|
| OS | Windows 10.0.18362 |
| Baseline | 6123cb00bbec8ae3500c970890f5b0efcf7950e8 |
| Compare | ffbcb8336ac67496b0565112f663f74fda6cac34 |
| Diff | Diff |
Improvements in System.Collections.IndexerSet<Int32>
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL |
|---|---|---|---|---|---|---|---|---|---|---|
| [IList - Duration of single invocation](<https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/refs/heads/main_x86_Windows 10.0.18362/System.Collections.IndexerSet(Int32).IList(Size%3a%20512).html>) | 1.93 μs | 1.78 μs | 0.92 | 0.03 | False |
_1.png>)
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.IndexerSet<Int32>*'
### Payloads
[Baseline]()
[Compare]()
### Histogram
#### System.Collections.IndexerSet<Int32>.IList(Size: 512)
```log
```
### Description of detection logic
```IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 1.7811928919623627 < 1.83086286208675.
IsChangePoint: Marked as a change because one of 1/13/2023 4:37:08 PM, 2/16/2023 6:27:39 AM, 3/6/2023 11:14:52 AM, 3/14/2023 10:43:28 AM falls between 3/5/2023 5:50:49 PM and 3/14/2023 10:43:28 AM.
IsImprovementStdDev: Marked as improvement because 16.81106794056998 (T) = (0 -1798.9623233250154) / Math.Sqrt((8938.718318035071 / (299)) + (5591.562368472954 / (36))) is greater than 1.9671134448822736 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (36) - 2, .975) and 0.11282893908857532 = (2027.7513577560485 - 1798.9623233250154) / 2027.7513577560485 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
```
### Docs
[Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md)
[Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
_1.png>)
_2.png>)
_3.png>)
_1.png>)
_1.png>)
_1.png>)
_2.png>)
Run Information
Improvements in PerfLabTests.CastingPerf2.CastingPerf
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
Baseline Compare
Run Information
Improvements in System.Memory.Span<Byte>
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
Baseline Compare
Run Information
Improvements in PerfLabTests.CastingPerf
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
Baseline Compare
Run Information
Improvements in System.Numerics.Tests.Perf_VectorOf<Int16>
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
Payloads
Baseline Compare