search

dotnet / perf-autofiling-issues

A landing place for auto-filed performance issues before they receive triage
MIT License
9 stars 4 forks source link

[Perf] Linux/x64: 5 Regressions on 8/23/2023 12:15:00 AM #20922

Open performanceautofiler[bot] opened 1 year ago

performanceautofiler[bot] commented 1 year ago

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 4a5695b6ea0e461e6527de057420872369345282
Compare 413eac805f0638da4bf10d71aeded06d5c22b829
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.Tests.Perf_BitArray

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
6.30 ns 7.87 ns 1.25 0.24 True
7.84 ns 10.20 ns 1.30 0.16 True
8.72 ns 10.13 ns 1.16 0.51 False

graph graph graph Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Tests.Perf_BitArray*'
### Payloads [Baseline]() [Compare]() ### System.Collections.Tests.Perf_BitArray.BitArraySetAll(Size: 512) #### ETL Files #### Histogram #### Description of detection logic ``` IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsRegressionWindowed: Marked as regression because 7.86653674689372 > 6.615527215284947. IsChangePoint: Marked as a change because one of 8/22/2023 4:48:44 PM, 8/28/2023 11:06:53 PM falls between 8/19/2023 11:06:43 PM and 8/28/2023 11:06:53 PM. IsRegressionStdDev: Marked as regression because -28.863982614390462 (T) = (0 -7.957856639353524) / Math.Sqrt((0.005754544888972487 / (17)) + (0.051263774379482915 / (18))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (17) + (18) - 2, .025) and -0.2574606294830146 = (6.3285135556293906 - 7.957856639353524) / 6.3285135556293906 is less than -0.05. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsChangeEdgeDetector: Marked as regression because Edge Detector said so. ``` #### JIT Disasms ### System.Collections.Tests.Perf_BitArray.BitArrayNot(Size: 512) #### ETL Files #### Histogram #### Description of detection logic ``` IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsRegressionWindowed: Marked as regression because 10.195504162977466 > 8.262261270404384. IsChangePoint: Marked as a change because one of 8/23/2023 12:15:00 AM, 8/28/2023 11:06:53 PM falls between 8/19/2023 11:06:43 PM and 8/28/2023 11:06:53 PM. IsRegressionStdDev: Marked as regression because -8.570598207559462 (T) = (0 -9.826436544650063) / Math.Sqrt((0.0029362991406224155 / (18)) + (0.8607899208402372 / (17))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (18) + (17) - 2, .025) and -0.2446778238925307 = (7.894763091319049 - 9.826436544650063) / 7.894763091319049 is less than -0.05. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsChangeEdgeDetector: Marked as regression because Edge Detector said so. ``` #### JIT Disasms ### System.Collections.Tests.Perf_BitArray.BitArrayOr(Size: 512) #### ETL Files #### Histogram #### Description of detection logic ``` IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsRegressionWindowed: Marked as regression because 10.130378932532077 > 9.133730953618464. IsChangePoint: Marked as a change because one of 8/26/2023 7:53:22 PM, 8/28/2023 11:06:53 PM falls between 8/19/2023 11:06:43 PM and 8/28/2023 11:06:53 PM. IsRegressionStdDev: Marked as regression because -2.6512158001088144 (T) = (0 -10.619099153854451) / Math.Sqrt((0.3152398012172179 / (29)) + (1.9417670648842669 / (6))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (29) + (6) - 2, .025) and -0.16876459042412317 = (9.085746814079108 - 10.619099153854451) / 9.085746814079108 is less than -0.05. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so. ``` #### JIT Disasms ### Docs [Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md) [Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 4a5695b6ea0e461e6527de057420872369345282
Compare 413eac805f0638da4bf10d71aeded06d5c22b829
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in Benchstone.BenchI.TreeInsert

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
48.57 Ξs 54.63 Ξs 1.12 0.04 False

graph Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Benchstone.BenchI.TreeInsert*'
### Payloads [Baseline]() [Compare]() ### Benchstone.BenchI.TreeInsert.Test #### ETL Files #### Histogram #### Description of detection logic ``` IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsRegressionWindowed: Marked as regression because 54.630371802156176 > 51.83959054756646. IsChangePoint: Marked as a change because one of 8/8/2023 9:37:01 AM, 8/22/2023 4:48:44 PM, 8/28/2023 11:06:53 PM falls between 8/19/2023 11:06:43 PM and 8/28/2023 11:06:53 PM. IsRegressionStdDev: Marked as regression because -14.651826019909642 (T) = (0 -52446.079212403376) / Math.Sqrt((212786.85062026535 / (17)) + (636917.5370745267 / (18))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (17) + (18) - 2, .025) and -0.06512574748180643 = (49239.33097702083 - 52446.079212403376) / 49239.33097702083 is less than -0.05. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so. ``` #### JIT Disasms ### Docs [Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md) [Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 4a5695b6ea0e461e6527de057420872369345282
Compare 413eac805f0638da4bf10d71aeded06d5c22b829
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Memory.SequenceReader

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
80.66 ns 85.99 ns 1.07 0.29 False

graph Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Memory.SequenceReader*'
### Payloads [Baseline]() [Compare]() ### System.Memory.SequenceReader.TryReadTo #### ETL Files #### Histogram #### Description of detection logic ``` IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small. IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline. IsRegressionWindowed: Marked as regression because 85.9926145067402 > 85.74653071053936. IsChangePoint: Marked as a change because one of 8/22/2023 4:48:44 PM, 8/28/2023 11:06:53 PM falls between 8/19/2023 11:06:43 PM and 8/28/2023 11:06:53 PM. IsRegressionStdDev: Marked as regression because -5.4279141624009934 (T) = (0 -87.47830331073354) / Math.Sqrt((8.953954331495646 / (17)) + (6.503080749707057 / (18))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (17) + (18) - 2, .025) and -0.06210142090569477 = (82.36341802098092 - 87.47830331073354) / 82.36341802098092 is less than -0.05. IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small. IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so. ``` #### JIT Disasms ### Docs [Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md) [Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
cincuranet commented 1 year ago

The diff, especially for BitArray is https://github.com/dotnet/runtime/compare/3a9412266ac60dc5e6156909ab2ddb9e89eb0df8...96c2e1d099a427a0c7f432c0c1ff7b2ec485b583. But nothing suspicious there. Any ideas @EgorBo @AndyAyersMS?