search

dotnet / performance

This repo contains benchmarks used for testing the performance of all .NET Runtimes
MIT License
691 stars 268 forks source link

[wasm] Cirtuclar Dependency Error running benchmarks using wasm with out a custom runtime pack #1518

Open naricc opened 4 years ago

naricc commented 4 years ago

Repo:

$MYDOTNET here points at a dotnet host using net5.0:

> $MYDOTNET run -c Release --framework netcoreapp5.0  MicroBenchmarks.csproj --filter "*Burgers*" --cli $MYDOTNET --runtimes wasm   --wasmMainJS $HOME/workspace/runtime-wasm-test-build//src/mono/wasm/runtime-test.js

THe harness will run, but individual benchmarks will fail with this error:

/Users/naricc/workspace/performance-fan-repro/artifacts/bin/MicroBenchmarks/Release/netcoreapp5.0/d94a3150-1519-452d-9b76-f8309de68843/BenchmarkDotNet.Autogenerated.csproj(27,11): error MSB4006: There is a circular dependency in the target dependency graph involving target "Publish".
Build FAILED.

This error doesn't occur if a custom runtime pack is specified with --customRuntimePack (probably the most common use case for wasm).

I'm not sure if this is a problem for dotnet/runtime or dotnet/performance, but I am putting it here for now. It may have something to do with a change in how wasm apps are constructed.

kg commented 3 years ago

I also have this problem, it's not clear how I'm meant to run benchmarks without hitting this

billwert commented 3 years ago

@naricc Is this still relevant? Or has it been fixed by any of your other work in this space?