search

dotnet / performance

This repo contains benchmarks used for testing the performance of all .NET Runtimes
MIT License
691 stars 268 forks source link

Remove INTERNAL_DI from DI tests #1583

Open maryamariyan opened 3 years ago

maryamariyan commented 3 years ago

This issue tracks work to refactor DI tests in microbenchmarks to remove INTERNAL_DI. (Related to tests perf tests requiring InternalsVisibleTo) https://github.com/dotnet/performance/blob/84681752ab38aaffa48e6221006842f016b43448/src/benchmarks/micro/libraries/Microsoft.Extensions.DependencyInjection/TimeToFirstServiceBenchmark.cs#L21-L23

billwert commented 3 years ago

@maryamariyan Did this ever happen?

maryamariyan commented 3 years ago

@maryamariyan Did this ever happen?

No, just double checked this issue is still open.