Closed LoopedBard3 closed 3 years ago
@naricc @LoopedBard3 - scanning through above error - see this : You need to add 'net6.0' to
Also way above in the log it says Targetting net7.0 -- so possibly a version mismatch somewhere ?
@SamMonoRT - I agree that there seems to be some versioning issue somewhere. I would checkout the attached issue dotnet/BenchmarkDotNet#1827 as it provides a little bit more context.
I had trouble reproducing this locally, but I think I figured this out. When we are running locally, this condition is true: https://github.com/dotnet/performance/blob/e7e94530cdce988f381ce053d28b1ee6f9d45c95/src/benchmarks/micro/MicroBenchmarks.csproj#L7, so we get all the frameworks.
In CI, however, the condition is false and TargetFrameworks is already set by the scripts. So it ends up with only .net7 in the script, which does not agree with the TargetFramework in the project generated by BDN. I will need to fix this in a way similar to what was done for wasm here: https://github.com/dotnet/BenchmarkDotNet/pull/1592
I have put up the PR that should fix this when merged. But it will require pulling a new version of Benchmark Dotnet. Who is making that change? @LoopedBard3 @DrewScoggins ?
@LoopedBard3 @DrewScoggins I don't think this is actually closed yet, right? The change on the dotnet/performance side to pull the new BDN version isn't in? But I don't appear to have the permissions to reopen the issue.
@naricc I agree that it is not ready to be closed yet. Without changing anything in the perf repo, the MonoAOTLLVM runs are still failing in the main pipeline.
@LoopedBard3 - not sure how these two issues are related. What we need for this is a change very similar to this old one where we update the right BDN version with the fix : https://github.com/dotnet/performance/pull/2039/files
These two changes were not related, but since both were small changes I just stuck them in the same PR. Probably not the best way to do it.
There is a target framework error causing benchmark to not build, in turn preventing the tests from running. The issue here is just to help track dotnet/benchmarkdotnet#1827. Full Error: