dotnet / performance

This repo contains benchmarks used for testing the performance of all .NET Runtimes
MIT License
684 stars 263 forks source link

Truly Dynamic Event #4274

Closed cshung closed 1 month ago

cshung commented 2 months ago

This PR is currently in a prototype state. (It is easier to review by commits)

This change:

  1. Upgrade TraceEvent dependencies from 3.1.7 to 3.1.9, which also require upgrading the project to 8.0, so that we can
  2. Allow using custom TraceEvent library, built some support for using it, to
  3. Parse DynamicEvent and allow them to be accessed in the Notebooks.

And some other cleanups

  1. Run dotnet-format on the source code
  2. Ignore xlf files
  3. Deleted unwanted (and failing) outputs from Notebook examples.

The dynamic event consumption part can only work with https://github.com/microsoft/perfview/pull/2051.

mrsharm commented 1 month ago

@cincuranet - could we please get this PR merged, seems like the Build Analysis failures are unrelated:

❌The pipeline is not valid. Job windows_22H2_x64_scenarios__Open: Step AzureCLI input connectedServiceNameARM references service connection .NET Performance (790c4451-dad9-4fda-af8b-10bd9ca328fa) which could not be found. The service connection does not exist, has been disabled or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz. Job ubuntu_2204_x64_scenarios__Open: Step AzureCLI input connectedServiceNameARM references service connection .NET Performance (790c4451-dad9-4fda-af8b-10bd9ca328fa) which could not be found. The service connection does not exist, has been disabled or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz.

Thanks!

cincuranet commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
cincuranet commented 1 month ago

@LoopedBard3 @DrewScoggins @caaavik-msft @sblom PTAL

LoopedBard3 commented 1 month ago

Error was fixed earlier this week and this PR is approved by correct people, merging 👍.