search

dotnet / performance

This repo contains benchmarks used for testing the performance of all .NET Runtimes
MIT License
684 stars 263 forks source link

Surround obsolete X509Certificate2 load in tests with warning disable. #4300

Closed LoopedBard3 closed 1 month ago

LoopedBard3 commented 1 month ago

Surround obsolete X509Certificate2 load in tests with warning disable. We started hitting errors when building the microbenchmarks due to the changes made for https://github.com/dotnet/runtime/issues/91763 making their way through to the daily SDK we use to build the benchmarks. Disabling the warning will get the benchmarks running again as we figure out how we want to update the certificate retrieval as the X509CertificateLoader is new and not available on versions < net9.0-preview.7 AFAICT.

First runtime-perf build that hit the issue: https://dev.azure.com/dnceng/internal/_build/results?buildId=2490580&view=results

LoopedBard3 commented 1 month ago

Locally tested and necessary for any success so merging.