dotnet / performance

This repo contains benchmarks used for testing the performance of all .NET Runtimes
MIT License
687 stars 267 forks source link

Use correct python executable inside venv for perf tests on Windows #4339

Closed caaavik-msft closed 1 month ago

caaavik-msft commented 1 month ago

Previously we were using py -3 to run python on Windows machines, however after we activated the python venv, the python executable is just python. We had a few machines that had some corrupt or broken global python installs (#4242) and so jobs were failing on them, with this change we will now be properly isolated from issues with the global python installation.

In addition, I also added an extra command after venv activation to re-enable echo. For some reason the venv activation script turns echo off and then doesn't re-enable it at the end, so with this change we can now see all the commands that are run inside the venv on Windows.