search

dotnet / pinvoke

A library containing all P/Invoke code so you don't have to import it every time. Maintained and updated to support the latest Windows OS.
MIT License
2.12k stars 222 forks source link

Some Kernel32 functions #246

Closed arlm closed 8 years ago

arlm commented 8 years ago

As I was looking around on the enums, I have noticed that some introduced a zero-state None field, but the naming is inconsistent. Some are just None, some follow the inner enum naming system like SH_FLAG_NONE. which one is the most appropriate? If it is the inner naming system, can I add the fix to this commit?

vbfox commented 8 years ago

On the zero state I think it could be nice to avoid using default(EnumName). For the name I think it would be named None as we try to respect the C# naming except when something already have a name in the original header files.

vbfox commented 8 years ago

Except for GetProcAddress movement, LGTM.

4 PRs in a row :+1: :beers:

arlm commented 8 years ago

Ohhh damn. I tried moving SafeLibraryHandle but the CodeGenerator started throwing all kinds of complains. Can you help me move SafeLibraryHandle to Shared to be able to use GetProcAddress on UWA and Desktop?

I will be out tomorrow and will resume my activities only on Friday, so no commits tomorrow :cry:

AArnott commented 8 years ago

Thanks!