Closed arlm closed 8 years ago
Done reviewing. Looks pretty good, with comments.
LGTM, might need to continue the discussion on ACCESS_MASK before merge.
Anything else on this PR do you think needs working?
Now that I've merged your other PR, we have merge conflicts. Can you resolve them?
I'm guessing in the sln file, since VS doesn't maintain order so it just produces noise. If it is, I suggest you just take left or right for that whole section of the .sln file, then reopen the solution, and force-save it (click on the solution node in Solution Explorer, then click File->Save) so that VS will make sure that the right entries are present.
I've left a few more comments. It's nearly ready. :)
Regarding your attempt in 8a1b142 to appease AppVeyor, you should be able to reproduce any build errors locally by using build.ps1 -WarnAsError
Yeah, but now I am not at work and am doing stuff on a Mac using Xamarin at home. By the way I lost many of the project features and settings because of this. For more than a month I have this dark wish to port the NuProj support to Xamarin and to change our project scripts or create a new one to be able to do stuff without the PowerShell on my personal machine.
Don't be surprised if in the future I indulge to these dark wishes and start to do weird commits here and on NuProj project (I noticed you are a developer/contributor there also). Maybe the proper place might not be on the NuProj project and it should be fork. I don't know. Now that Microsoft has Miguel de Icaza and Xamarin team onboard things seems to be changing really fast on the Mono/Xamarin environment. I wouldn't be surprised to have the plugin/extension APIs on Xamarin Studio/MonoDevelop change suddenly to something more akin to the VS model of APIs.
Ohh man, bad, bad, bad changes. I really didn't want to indulge to porting the scripts right now but it got worse. Now the tests for Kernel32 are broken. I really don't know where does it came from. I didn't do anything on those XML Docs or functions. It might be something from the merge. I will look closely into that and might need to port some of the scripts to test. I don't have project.json support on Xamarin, neither it does allow to restore NuGet packages (it recognizes none on the projects). Luckily it has MSBuild support on the version I am in (the beta one) and all projects seems to be using it.
I'm taking a look myself. Let's chat on gitter
Thanks so much for your contribution and especially your persistence on this. You hit a few very interesting growth areas for this project and I feel like the time was well spent so our library can maintain its stable API going forward. 💯
I am happy to have it stable on the library
This is the first part of the pull request, to be reviewed with care and love 😁.
This commits have the Window Station and Desktop API. After review I will update it with the other APIs.