search

dotnet / pinvoke

A library containing all P/Invoke code so you don't have to import it every time. Maintained and updated to support the latest Windows OS.
MIT License
2.12k stars 222 forks source link

Add missing enum values #279

Closed vbfox closed 8 years ago

vbfox commented 8 years ago

Fixes #278

Note: No idea if it build as my work PC can't build the solution at the moment, showing :

The package 'StyleCop.Analyzers/1.0.0' could not be found in the libraries section of the lock file. This may indicate your lock file is corrupted.

So i'll let appveyor decide :)

vbfox commented 8 years ago

I'll use this PR to also fix #280

AArnott commented 8 years ago

LGTM. After this, the policy to always specify values (perhaps by writing an analyzer) sounds even better.

vbfox commented 8 years ago

Yes while I think we should allow still allow to not specify them when they aren't in the header files, we should have an analyzer and only suppress it after the header file have been checked and a comment is added.

// Sequential values are used in the original header file (WinUser.h)
#pragma warning disable XXXX

It's a lot more specific an would avoid "OOPS" cases like this