search

dotnet / pinvoke

A library containing all P/Invoke code so you don't have to import it every time. Maintained and updated to support the latest Windows OS.
MIT License
2.12k stars 222 forks source link

Add ServiceType SERVICE_NO_CHANGE #327

Closed aluferYochay closed 7 years ago

AArnott commented 7 years ago

I agree with @vbfox that adding the value to each of the 3 enum's is probably the way to go.

aluferYochay commented 7 years ago

What it means that the SERVICE_NO_CHANGE is not part of the declared API ?

AArnott commented 7 years ago

@aluferYochay It looks from your commits that you're not sure how to get the build to work. I have two suggestions:

  1. Use the Format Document command in VS. That generally trims the whitespace and formats the code so that StyleCop is happy and should help you get the build to pass.
  2. Use the build.ps1 script in the root of the repo to check that the build will succeed before committing and pushing. It should give you a pretty accurate idea of whether it will work without having to run appveyor.

Squash your commits and force push when you get it working so we get a reasonably clean set of commits to merge.

AArnott commented 7 years ago

Thank you for your contribution, @aluferYochay

aluferYochay commented 7 years ago

Hi I have few errors when running the build script, different from "not part of the declared API.." out.txt

Can you advice on how to resolve ?

AArnott commented 7 years ago

Did you run build.ps1 without parameters, or did you run it with -Restore at least once?

aluferYochay commented 7 years ago

I ran it with restore..

AArnott commented 7 years ago

Hmmm... I don't know what the problem would be then. I'm preparing a commit to fix the remaining issues.

AArnott commented 7 years ago

Thank you for your contribution, @aluferYochay