API's implemented in headers

dotnet / pinvoke

A library containing all P/Invoke code so you don't have to import it every time. Maintained and updated to support the latest Windows OS.

MIT License

2.12k stars 222 forks source link

API's implemented in headers #357

Closed ghost closed 4 years ago

ghost commented 6 years ago

Consider IsWindowsVersionOrGreater.

Where should something like this be implemented ?

In a new class (VersionHelpers.dll) ?
In Windows.Core, as a new type (PInvoke.VersionHelpers, exposed via Windows.Core)?
Nowhere - it's not, strictly speaking, PInvoke - so take it over to a more apt project like WinApi
some other recommendation ?

AArnott commented 4 years ago

I think WinApi is a fine choice. If the header file it comes from maps directly to one of the libraries for which we have p/invokes, I don't think I'd object to defining it in one of our libraries though.