Refactor usage of NTSTATUS.SeverityShift - Githubissues

dotnet / pinvoke

A library containing all P/Invoke code so you don't have to import it every time. Maintained and updated to support the latest Windows OS.

MIT License

2.11k stars 220 forks source link

Refactor usage of NTSTATUS.SeverityShift #603

Closed BinToss closed 1 year ago

BinToss commented 2 years ago

Closes dotnet/pinvoke#600

refactor bit shift of enum NTSTATUS.SeverityCode to property NTSTATUS.Severity
refactor NTStatusFacts.Severity() to acknowledge new bit equation.

BREAKING CHANGE

All values of enum NTSTATUS.SeverityCode have changed!

BinToss commented 2 years ago

A PR to refactor NTSTATUS.FacilityShift will follow this PR's merge.

BinToss commented 2 years ago

I realized I left out the HResult refactor...

and broke the API check...

BinToss commented 2 years ago

Alright. I'm fairly certain I crossed all the "t"s and dotted all the "i"s. FacilityShift/FacilityCode/Faciility changes are ready for a separate PR, too.

Last build after the force-push: https://dev.azure.com/andrewarnott/OSS/_build/results?buildId=6763&view=logs&j=0bc77094-9fcd-5c38-f6e4-27d2ae131589&t=0bc77094-9fcd-5c38-f6e4-27d2ae131589

BinToss commented 2 years ago

btw, the PR check can be updated either by toggling the Draft/Ready state of the PR or by updating the workflow's triggers to "listen to the synchronize event".

AArnott commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago

Azure Pipelines successfully started running 1 pipeline(s).