Win exception thrown by System.IO.Directory.Move now thrown in Unix

dotnet / platform-compat

Roslyn analyzer that finds usages of APIs that will throw PlatformNotSupportedException on certain platforms.

MIT License

279 stars 43 forks source link

Win exception thrown by System.IO.Directory.Move now thrown in Unix #153

Closed carlossanlop closed 5 years ago

carlossanlop commented 5 years ago

It was suggested to me in issue https://github.com/dotnet/corefx/issues/33486 to make this update to indicate that an exception that was being thrown in Windows only, is now going to be thrown in Unix too.

Please let me know if the change was done in the right place and with the correct format.

joperezr commented 5 years ago

I'll defer to @terrajobst as I'm not familiar to how we usually add breaking changes to the analyzers here. Shouldn't we add some sort of text explaining what the differences in behavior is? Or is that not shown by the analyzers?

danmoseley commented 5 years ago

I think @carlossanlop you will have to figure out a bit about what this tool does. I agree with @joperezr that just making it flag this API is probably not desirable. Although I suggested this tool was the place to flag the problem, in fact maybe it is really for flagging API that simply don't work on a particular platform...