dotnet / project-system-tools

Tools for working with the C#/VB/F# project system.
MIT License
270 stars 42 forks source link

Remove incompatible code sign check #488

Closed haileymck closed 4 months ago

haileymck commented 4 months ago

pipeline run

This code signing validation is incompatible with Arcade pipelines. It is causing CodeSign.MissingSigningCert on all of the .dll that are in fact signed. This is because this code sign validation doesn't work with how this Arcade repo is signed. Thus, this code sign validation needs to be removed because it is an invalid check.

Signing is done here with the singing plugin and during build here:

https://github.com/dotnet/project-system-tools/blob/main/eng/common/templates-official/job/job.yml#L131

https://github.com/dotnet/project-system-tools/blob/7b89ddee00a91d80e54a7345d83e51a490c29309/eng/common/build.ps1#L60

I have manually verified that the .dlls are in fact being signed. For example, we can see that the Microsoft.VisualStudio.ProjectSystem.Tools.dll is being signed here: projectsystemtools projectsystemtoolsagain

Originally, this validation was copied over from a non-Arcade pipeline during the 1ES pipeline migration. In the future, we want to use Arcade signing validation in our pipeline; I created #487 to track.